733599 - mozContacts should use DOMRequestIpcHelper

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Gregor Wagner [:gwagner]]

This was introduced in Bug 720415

Comment 1

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 2

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 3

[Gregor Wagner [:gwagner]]

Hm DOMRequestIpcHelper is only available in gonk builds. I guess I have to move it out.

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 603543 [details] [diff] [review]
patch

Review of attachment 603543 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comments addressed

::: dom/contacts/ContactManager.js
@@ +289,5 @@
>        case "Contact:Save:Return:OK":
>        case "Contacts:Clear:Return:OK":
>        case "Contact:Remove:Return:OK":
>          req = this.getRequest(msg.requestID);
> +        debug("req:" + req);

remove

::: dom/contacts/fallback/ContactService.jsm
@@ +17,5 @@
>  let EXPORTED_SYMBOLS = ["DOMContactManager"];
>  
>  Cu.import("resource://gre/modules/XPCOMUtils.jsm");
>  Cu.import("resource://gre/modules/Services.jsm");
> +Cu.import("resource://gre/modules/DOMRequestHelper.jsm");

You don't need this in the parent.

@@ +52,5 @@
>      } catch(e) { debug(e); }
>    },
>  
>    observe: function(aSubject, aTopic, aData) {
> +    debug("custom observe!");

remove

Comment 5

[Gregor Wagner [:gwagner]]

Attachment: patch

Part2 with review comments and Makefile change

Comment 6

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a26a660d4911

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a26a660d4911