Closed Bug 733599 Opened 10 years ago Closed 10 years ago

mozContacts should use DOMRequestIpcHelper

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: gwagner, Assigned: gwagner)

Details

Attachments

(2 files, 1 obsolete file)

This was introduced in Bug 720415
Assignee: nobody → anygregor
Attached patch patch (obsolete) — Splinter Review
Attached patch patchSplinter Review
Attachment #603541 - Attachment is obsolete: true
Attachment #603543 - Flags: review?(fabrice)
Hm DOMRequestIpcHelper is only available in gonk builds. I guess I have to move it out.
Comment on attachment 603543 [details] [diff] [review]
patch

Review of attachment 603543 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comments addressed

::: dom/contacts/ContactManager.js
@@ +289,5 @@
>        case "Contact:Save:Return:OK":
>        case "Contacts:Clear:Return:OK":
>        case "Contact:Remove:Return:OK":
>          req = this.getRequest(msg.requestID);
> +        debug("req:" + req);

remove

::: dom/contacts/fallback/ContactService.jsm
@@ +17,5 @@
>  let EXPORTED_SYMBOLS = ["DOMContactManager"];
>  
>  Cu.import("resource://gre/modules/XPCOMUtils.jsm");
>  Cu.import("resource://gre/modules/Services.jsm");
> +Cu.import("resource://gre/modules/DOMRequestHelper.jsm");

You don't need this in the parent.

@@ +52,5 @@
>      } catch(e) { debug(e); }
>    },
>  
>    observe: function(aSubject, aTopic, aData) {
> +    debug("custom observe!");

remove
Attached patch patchSplinter Review
Part2 with review comments and Makefile change
Attachment #603832 - Flags: review?(fabrice)
Attachment #603543 - Flags: review?(fabrice) → review+
Attachment #603832 - Flags: review?(fabrice) → review+
https://hg.mozilla.org/mozilla-central/rev/a26a660d4911
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.