Closed
Bug 733630
Opened 12 years ago
Closed 11 years ago
It's difficult to resize window by dragging top border of it if the window shows Firefox button
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: masayuki, Assigned: masayuki)
References
()
Details
(Keywords: regression)
Attachments
(2 files, 3 obsolete files)
5.63 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
2.63 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
If Firefox button is displayed, it seems that the top border of the window is collapsed. At that time, I can see the mouse cursor which is for resizing (N-S, NW-SE, NE-SW) only on the topmost edge (maybe only 1px). It make me difficult to resize the window by dragging the top border of the window. Opera keeps the top window border except on the Opera button.
Assignee | ||
Comment 1•12 years ago
|
||
I think that the minimum size of border on blank area should be the system default value rather than 3px.
Assignee | ||
Comment 2•12 years ago
|
||
Updated my strange comment.
Attachment #631872 -
Attachment is obsolete: true
Attachment #631872 -
Flags: review?(jmathies)
Attachment #631877 -
Flags: review?(jmathies)
![]() |
||
Comment 3•12 years ago
|
||
for content click testing once I get this built.
![]() |
||
Comment 4•12 years ago
|
||
Comment on attachment 631877 [details] [diff] [review] Patch (In reply to Jim Mathies [:jimm] from comment #3) > for content click testing once I get this built. Per this test, this patch prevents the user from clicking content along a 1px border around the content area. We can't filter mouse clicks here.
Attachment #631877 -
Flags: review?(jmathies) → review-
Assignee | ||
Comment 5•12 years ago
|
||
Hmm, it seems that NS_MOUSE_MOZHITTEST event doesn't work with content area??
Assignee | ||
Comment 6•12 years ago
|
||
Okay, I see the cause. We're not performing to do the hit test if the result is left, right or bottom border. We should do it when cursor is inside the mNonClientMargin.
Attachment #631877 -
Attachment is obsolete: true
Attachment #633374 -
Flags: review?(jmathies)
Assignee | ||
Comment 7•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=116a81c7e855
Assignee | ||
Comment 8•12 years ago
|
||
Comment on attachment 633374 [details] [diff] [review] Patch Er, maybe, we should do the hit test at "==" too.
Attachment #633374 -
Flags: review?(jmathies)
Assignee | ||
Comment 9•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=4e97796f60d7
Attachment #633374 -
Attachment is obsolete: true
Attachment #633384 -
Flags: review?(jmathies)
![]() |
||
Updated•11 years ago
|
Attachment #633384 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 10•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0ede175182d
Target Milestone: --- → mozilla16
Comment 11•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a0ede175182d
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
![]() |
||
Comment 12•11 years ago
|
||
backed out: https://hg.mozilla.org/mozilla-central/rev/9c743145c60d
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 13•11 years ago
|
||
Wow, sorry for such big mistake and thank you for the report and backout. I'll check this tomorrow if I can, but maybe, next week.
Assignee | ||
Comment 14•11 years ago
|
||
I separated the additional change to this patch. If you like landing a patch, let me know it. The cause is, contentMayOverlap indicates if content may overlap the border. So, it's not necessary check. We need to do the hit test inside window border too.
Attachment #639214 -
Flags: review?(jmathies)
Assignee | ||
Comment 15•11 years ago
|
||
test builds here: https://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/masayuki@d-toybox.com-87fc79d4f05a/
Assignee | ||
Comment 16•11 years ago
|
||
jimm: ping test builds will be: https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=ff17ce2f2a2d
![]() |
||
Comment 17•11 years ago
|
||
Comment on attachment 639214 [details] [diff] [review] Additonal change Sorry! dropped off the radar.
Attachment #639214 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 18•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4abd71e551a2 https://hg.mozilla.org/integration/mozilla-inbound/rev/51daf14fd1f6
Target Milestone: mozilla16 → mozilla20
Comment 19•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4abd71e551a2 https://hg.mozilla.org/mozilla-central/rev/51daf14fd1f6
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•