Closed Bug 733651 Opened 12 years ago Closed 12 years ago

Snippet fails to load on about:home due to XMLHttpRequest.open error

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 14
Tracking Status
firefox13 --- fixed

People

(Reporter: fryn, Assigned: fryn)

References

()

Details

(Whiteboard: [about-home][qa-])

Attachments

(1 file)

Steps to reproduce:

1. Open Firefox so that about:home is the page immediately loaded and the update branch is taken in the function loadSnippets(). (This can artificially be induced by setting window.localStorage["snippets-last-update"] to 0 and then restarting Firefox without session restore enabled.)
2. No snippet appears, because the following exception is thrown:

Error: uncaught exception: [Exception... "Component returned failure code: 0x805e0006 [nsIXMLHttpRequest.open]"  nsresult: "0x805e0006 (<unknown>)"  location: "JS frame :: chrome://browser/content/abouthome/aboutHome.js :: loadSnippets :: line 223"  data: no]

I'm not exactly sure why this happens, but since it corrects itself upon a reload, my guess is that the XMLHttpRequest cannot be properly initialized.

This happens already on about:home in Firefox stable and is not due to the new visual refresh code.
Here's a workaround to ensure that at least the default snippets load.

We should still investigate why XMLHttpRequest.open throws.
Whiteboard: [about-home]
Comment on attachment 603582 [details] [diff] [review]
workaround to ensure that at least the default snippets load

please file a follow-up to investigate reasons for the exception and add a comment there pointing to that bug.
Attachment #603582 - Flags: review+
Pushed to fx-team:
https://hg.mozilla.org/integration/fx-team/rev/63612df32193

Filing followup next.
Assignee: nobody → fryn
Status: NEW → ASSIGNED
Whiteboard: [about-home] → [about-home][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/63612df32193

backported with bug 711157
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [about-home][fixed-in-fx-team] → [about-home]
Target Milestone: --- → Firefox 14
Whiteboard: [about-home] → [about-home][qa+]
Mozilla/5.0 (Windows NT 6.1; rv:13.0) Gecko/20100101 Firefox/13.0
BuildID: 20120528154913

I evaluated window.localStorage["snippets-last-update"]=0; in the Error Console and restarted Firefox. I didn't get the error from comment 0, but I got:

Error: self._interfaceBuilder is undefined
Source File: resource://testpilot/modules/setup.js
Line: 260 

Frank, is that ok or should I set window.localStorage["snippets-last-update"] to 0 some other way?
Regarding my previous message, when evaluating window.localStorage["snippets-last-update"]=0; in the Error Console, I get the following error:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIDOMWindow.localStorage]"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: javascript:%20window.localStorage["snippets-last-update"]=0; :: <TOP_LEVEL> :: line 1"  data: no]
(In reply to Ioana Budnar [QA] from comment #6)

This bug doesn't need further verification.
Thanks.
Whiteboard: [about-home][qa+] → [about-home][qa-]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: