733674 - B2G SMS: Fix off-by-one errors in timestamp computation

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Philipp von Weitershausen [:philikon]]

Don't know what I was smoking at the time, but that code definitely ain't right, as jstraus points out:

      let year   = this.readSwappedNibbleBCD(1) + PDU_TIMESTAMP_YEAR_OFFSET;
      let month  = this.readSwappedNibbleBCD(1) - 1;
      let day    = this.readSwappedNibbleBCD(1) - 1;
      let hour   = this.readSwappedNibbleBCD(1) - 1;
      let minute = this.readSwappedNibbleBCD(1) - 1;
      let second = this.readSwappedNibbleBCD(1) - 1;

year and month are correct, the rest isn't.

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Comment 2

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/mozilla-central/rev/7813816f7ff4