733694 - Add tests for major update

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

We have major update code and PPC/Intel architecture detection which isn't being tested.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Major update tests

3.6.27 -> 10.0.2 major updates. Note the extra alias at the top of Firefox-10.0.2-build1.json to catch the old buildTarget using an otherwise-stock 10.0.2 blob. One typo fix to make major updates work.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 607040 [details] [diff] [review]
Major update tests

Review of attachment 607040 [details] [diff] [review]:
-----------------------------------------------------------------

::: auslib/AUS.py
@@ -208,4 @@
>              # AUS2 snippets have a trailing newline, add one here for easy diffing
>              snippets[patch['type']] = "\n".join(snippet) + '\n'
> -        # XXX: need to handle old releases needing completes duplicating partials
> -        # add another parameter in the rule table and use it here

Do we not need to handle duplicate partials anymore, or did this already get handled somewhere?

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

We should just set fakePartials in release blobs for 3.6 or older, and have a copy of later release blobs with it set for major updates from 3.6 or older (or make good on my idea to have a bag of properties attached to each rule rather than stuff them in release blobs).

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 607040 [details] [diff] [review]
Major update tests

https://github.com/mozilla/balrog/commit/57f104f218

Comment 5

[[e-mail] (:bhearsum)]

(In reply to Nick Thomas [:nthomas] from comment #3)
> We should just set fakePartials in release blobs for 3.6 or older, and have
> a copy of later release blobs with it set for major updates from 3.6 or
> older (or make good on my idea to have a bag of properties attached to each
> rule rather than stuff them in release blobs).

Sounds good either way.

Comment 6

[[e-mail] (:bhearsum)]

Bulk move of bugs to Release Automation component.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

PPC/Intel stuff farmed out to bug 757321.