733758 - Inspecting the value of a CDataFinalizer without calling forget

Status: RESOLVED WONTFIX

(Core :: js-ctypes, enhancement)

Description

[David Teller [:Yoric] - still alive but not very active]

At the moment, CDataFinalizer will not let code inspect the value held without calling |forget|. I have come across at least one case blocked by this: extracting the value from the finalizer to send it to a worker thread.

Just as Scoped pointers have a method |get|, we should have a method |value| to extract the value without calling |forget|.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: Implementation of attribute |value|

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Attachment: Companion testsuite

Comment 3

[Jason Orendorff [:jorendorff]]

Comment on attachment 603717 [details] [diff] [review]
Implementation of attribute |value|

Looks like the right idea.

In the test, I think this line is wrong because it assumes GC did not run:
>+  do_check_eq(count_finalized(size, tc), 0);

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Thanks for the feedback.

Taras has managed to convince me that I should try and implement OS.File without using this, so I am not going to push that patch much forward for the moment.

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Turns out that we can simply cast a CDataFinalizer to its type using ctypes.cast, so this feature is useless.