73387 - Keep naming of the IMAP files consistent

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Håkan Waara]

I saw that some of the files in imap/src was named "nsIMAP*.cpp" and some
"nsImap*.cpp".

Most of the files in mailnews/* are named nsSmtp, nsUrl and so on.. so we should
keep the naming consistent.

patch coming up...please r= and sr=

Comment 1

[Håkan Waara]

Attachment: fix

Comment 2

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

- I'd like to see the complete CVS diffs for removing and adding the files, as 
  well.
- The class names should match the files (well, vice versa), so something will
  have to be changed there as well.
- nsIMAPFoo is better than nsImapFoo, because IMAP is an acronym and is 
  therefore properly spelled with capitals.

Seth has a bug on this already.

Comment 3

[Håkan Waara]

Well, that's another cup of tea.  :)

Comment 4

[timeless]

No. it's the same cup of tea.

Comment 5

[(not reading, please use [e-mail] instead)]

my bug was for all the inconsistencies in mozilla/mailnews/news.

to fix this right, we should do what shaver suggests: name the files properly and 
fix all the classes to have proper names.

but this is too much risk for not enough gain.  (It helps developers, yes, but it 
doesn't do squat for end users.)

we should stay focused on fixing bugs / implementing important missing features.

I'd mark this future, way future.

Comment 6

[Wayne Mery (:wsmwk)]

obsolete?

Comment 7

[Magnus Melin [:mkmelin]]

Seems still relevant.

Comment 8

[Magnus Melin [:mkmelin]]

Attachment: bug73387_IMAPrenames.patch

Compiled locally. Sent to try now to make sure there were are no surprises - https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=a175a5e56b6313ca2f4eedebc2d015977026da80

Comment 9

[gene smith]

Comment on attachment 9189761 [details] [diff] [review]
bug73387_IMAPrenames.patch

Review of attachment 9189761 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I wasn't sure at first if you changed the file names but I see you did. You might consider changing the commit message from
Bug 73387 - rename IMAP classes to be consistently Imap. 
to
Bug 73387 - rename IMAP files and classes to be consistently Imap.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d503d81adf6c
rename IMAP files and classes to be consistently Imap. r=gds