Last Comment Bug 733951 - Qt port does not compile anymore due to bad includes order
: Qt port does not compile anymore due to bad includes order
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: mozilla13
Assigned To: Oleg Romashin (:romaxa)
:
Mentors:
Depends on:
Blocks: 674753
  Show dependency treegraph
 
Reported: 2012-03-07 16:31 PST by Oleg Romashin (:romaxa)
Modified: 2012-03-13 04:50 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Optimize Preference.h include (1.16 KB, patch)
2012-03-07 16:33 PST, Oleg Romashin (:romaxa)
no flags Details | Diff | Splinter Review
Move nsI and moz_malloc wrapper includes after Qt includes (1.33 KB, patch)
2012-03-09 12:51 PST, Oleg Romashin (:romaxa)
jmuizelaar: review+
Details | Diff | Splinter Review
Added comment about includes conflicts. (1.96 KB, patch)
2012-03-12 11:51 PDT, Oleg Romashin (:romaxa)
no flags Details | Diff | Splinter Review

Description Oleg Romashin (:romaxa) 2012-03-07 16:31:58 PST
Attempt to compile m-c, fail for Qt port N9 phone
GLContextProviderEGL.cpp
c++ -o GLContextProviderEGL.o -c  -fvisibility=hidden -DMOZ_GLUE_IN_PROGRAM -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES -DSTATIC_EXPORTABLE_JS_API -DOSTYPE=\"Linux2.6\" -DOSARCH=Linux  -Igfx/gl -I. -I../../dist/include -I../../dist/include/nsprpub  -Iobj-build/dist/include/nspr -Iobj-build/dist/include/nss      -fPIC  -frtti -pedantic -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-invalid-offsetof -Wno-variadic-macros -Werror=return-type -Wno-long-long -fno-exceptions -fno-strict-aliasing -std=gnu++0x -pthread -ffunction-sections -fdata-sections -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -O3 -g -fomit-frame-pointer -Iobj-build/dist/include/cairo -DQT_SHARED -I/usr/include/meegotouch -I/usr/include/qt4 -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtCore   -DQT_SHARED -I/usr/include/qt4 -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtOpenGL   -DQT_SHARED -I/usr/include/qmsystem2 -I/usr/include/qt4 -I/usr/include/qt4/QtCore   -I/usr/include/qt4/QtMobility -I/usr/include/qt4/QtSensors -I/usr/include/qt4/QtFeedback -I/usr/include/qt4/QtLocation     -DMOZILLA_CLIENT -include ../../mozilla-config.h -MD -MF .deps/GLContextProviderEGL.pp gfx/gl/GLContextProviderEGL.cpp
In file included from /usr/include/qt4/QtCore/qstring.h:46,
                 from /usr/include/qt4/QtCore/qobject.h:48,
                 from /usr/include/qt4/QtGui/qwidget.h:46,
                 from /usr/include/qt4/QtOpenGL/qgl.h:45,
                 from /usr/include/qt4/QtOpenGL/QGLContext:1,
                 from gfx/gl/GLContextProviderEGL.cpp:52:
/usr/include/qt4/QtCore/qbytearray.h:370: error: macro "realloc" requires 2 arguments, but only 1 given
/usr/include/qt4/QtCore/qbytearray.h:418: error: macro "realloc" requires 2 arguments, but only 1 given
/usr/include/qt4/QtCore/qbytearray.h:432: error: macro "realloc" requires 2 arguments, but only 1 given
/usr/include/qt4/QtCore/qbytearray.h:435: error: macro "realloc" requires 2 arguments, but only 1 given
Comment 1 Oleg Romashin (:romaxa) 2012-03-07 16:33:41 PST
Created attachment 603911 [details] [diff] [review]
Optimize Preference.h include
Comment 2 Oleg Romashin (:romaxa) 2012-03-09 12:51:38 PST
Created attachment 604498 [details] [diff] [review]
Move nsI and moz_malloc wrapper includes after Qt includes

Problem similar to problem in bug 587715
Comment 3 Jeff Muizelaar [:jrmuizel] 2012-03-12 09:23:16 PDT
Comment on attachment 604498 [details] [diff] [review]
Move nsI and moz_malloc wrapper includes after Qt includes

Please, add a comment to the Qt includes about the ordering dependency.
Comment 4 Oleg Romashin (:romaxa) 2012-03-12 11:51:52 PDT
Created attachment 605036 [details] [diff] [review]
Added comment about includes conflicts.
Comment 5 Marco Bonardo [::mak] (Away 6-20 Aug) 2012-03-13 04:50:57 PDT
https://hg.mozilla.org/mozilla-central/rev/2eacd5a91b5f

Note You need to log in before you can comment on or make changes to this bug.