733987 - Add remove API to test Sync HTTP server

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Gregory Szorc [:gps]]

Attachment: Add ServerCollection.remove()

Trivial patch to add extra functionality to test HTTP server to remove records completely from the server. I want this to make testing 404's easier. It's a lot easier than installing a custom HTTP handler.

Comment 1

[Richard Newman [:rnewman]]

Comment on attachment 603940 [details] [diff] [review]
Add ServerCollection.remove()

Review of attachment 603940 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/sync/tests/unit/head_http_server.js
@@ +295,5 @@
>      return this.insertWBO(new ServerWBO(id, payload, modified));
>    },
>  
> +  /**
> +   * Removes a BSO entirely from the collection.

For consistency, either s/BSO/WBO until the next protocol version lands, or just say "object" instead.

Comment 2

[Gregory Szorc [:gps]]

https://hg.mozilla.org/services/services-central/rev/c90e6695df90

Comment 3

[Gregory Szorc [:gps]]

Not used anywhere, no QA needed.

Comment 4

[Richard Newman [:rnewman]]

https://hg.mozilla.org/mozilla-central/rev/c90e6695df90