Last Comment Bug 734041 - Linkification add-on breaks about:memory
: Linkification add-on breaks about:memory
Status: UNCONFIRMED
:
Product: Toolkit
Classification: Components
Component: about:memory (show other bugs)
: Trunk
: x86_64 Windows 7
: -- normal with 1 vote (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
:
: Nicholas Nethercote [:njn]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-08 04:21 PST by André Ziegler
Modified: 2012-05-14 21:44 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments

Description André Ziegler 2012-03-08 04:21:05 PST
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120307 Firefox/13.0a1
Build ID: 20120307031051

Steps to reproduce:

I tried to open about:memory in firefox


Actual results:

site is empty and Error console shows this error:

Fehler: uncaught exception: aboutMemory.js assertion failed: Unknown location


Expected results:

a full overview of all used memory
Comment 1 Nicholas Nethercote [:njn] 2012-03-08 04:51:33 PST
Thanks for the report.

This patch just modifies the assertion message to give more info:

https://hg.mozilla.org/integration/mozilla-inbound/rev/e986790701f3

André, can you please tell me what it prints once you've updated to a Nightly build that contains this patch?  Thank you!
Comment 2 André Ziegler 2012-03-08 07:06:47 PST
I'll do this after getting the next l10n nightly update which contains your changeset.
Comment 3 Marco Bonardo [::mak] 2012-03-09 05:09:19 PST
https://hg.mozilla.org/mozilla-central/rev/e986790701f3
Comment 4 André Ziegler 2012-03-09 10:43:51 PST
it still doesn't include anything useful:

Zeitstempel: 09.03.2012 19:35:02
Fehler: uncaught exception: aboutMemory.js assertion failed: Unknown location: 


I'm using Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120309 Firefox/13.0a1 which should contain the fix according to the pushlog:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=08809a43e082&tochange=ead9016b4102
Comment 5 André Ziegler 2012-03-09 10:52:33 PST
Here is the about:support page:


  Allgemeine Informationen

        Name
        Firefox

        Version
        13.0a1

        User-Agent
        Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120309 Firefox/13.0a1

        Profilordner

          Ordner anzeigen

        Aktivierte Plugins

          about:plugins

        Build-Konfiguration

          about:buildconfig

        Absturzberichte

          about:crashes

        Speicherverwendung

          about:memory

  Erweiterungen

        Name

        Version

        Aktiviert

        ID

        Add-on Compatibility Reporter
        1.1
        true
        compatibility@addons.mozilla.org

        Current Pushlog
        1.2
        true
        jid1-WwVLR26pEIqm1A@jetpack

        Extended Statusbar
        1.5.8
        true
        {daf44bf7-a45e-4450-979c-91cf07434c3d}

        Linkification
        1.3.9
        true
        {35106bca-6c78-48c7-ac28-56df30b51d2a}

        QuickRestart
        1.1.6
        true
        {F645A8C9-E969-42D9-B3F3-F325537222FD}

        Tab Mix Plus
        0.4.0.1pre.120308a
        true
        {dc572301-7619-498c-a57d-39143191b318}

        UI Fixer
        1.4.4
        true
        ff4uifix@nikolakocic.com

        About startup
        0.1.8
        false
        aboutstartup@glandium.org

        about:nosy
        0.2
        false
        jid1-O23HSUjp6N0lVA@jetpack

        about:telemetry
        0.9.1
        false
        ping.telemetry@mozilla.com

        Adblock Plus
        2.0.3
        false
        {d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}

        Auto Copy
        1.0.1
        false
        {0FED7D55-65D4-47b6-A6DE-9A4ADB55355F}

        BBCode
        0.5.3.1
        false
        {AE37D527-6604-461c-8102-975CF8053A2F}

        Bookmark Duplicate Detector
        1.0.7
        false
        {ba243cb0-b824-4a26-9418-73ee795d9b9d}

        Browser-Add-on zur Deaktivierung von Google Analytics
        0.9.6
        false
        {6d96bb5e-1175-4ebf-8ab5-5f56f1c79f65}

        CheckPlaces
        2.6.1
        false
        checkplaces@andyhalford.com

        Cycle Collector Analyzer, about:ccdump
        0.4.1
        false
        ccdump@getfirebug.com

        Dictionary Switcher
        1.3.2
        false
        dictionary-switcher@design-noir.de

        Element Hiding Helper für Adblock Plus
        1.2.1
        false
        elemhidehelper@adblockplus.org

        Expire history by days
        1.1
        false
        expire-history-by-days@bonardo.net

        external IP
        0.9.9.6
        false
        externalip@erik.morlin

        Flagfox
        4.1.12
        false
        {1018e4d6-728f-4b20-ad56-37578a4de76b}

        FlashGot
        1.4
        false
        {19503e42-ca3c-4c27-b1e2-9cdb2170ee34}

        Greasemonkey
        0.9.18
        false
        {e4a8a97b-f2ed-450b-b12d-ee082ba24781}

        Hide My Ass Proxy Extension
        1.2.6
        false
        extension@hidemyass.com

        Nightly Tester Tools
        3.2.1.1
        false
        {8620c15f-30dc-4dba-a131-7c5d20cf4a29}

        No-Referer
        1.3.2
        false
        {e806da17-8400-4b6b-9c34-1bb4fe84aedc}

        NoScript
        2.3.4rc1
        false
        {73a6fe31-595d-460b-a920-fcc0f8843232}

        NoSquint
        2.1.5
        false
        nosquint@urandom.ca

        Password Exporter
        1.2.1
        false
        {B17C1C5A-04B1-11DB-9804-B622A1EF5492}

        Places Maintenance
        1.3
        false
        places-maintenance@bonardo.net

        ProxTube - Gesperrte YouTube Videos entsperren
        1.3.4
        false
        ich@maltegoetz.de

        Redirect Remover
        2.6.4
        false
        {fe0258ab-4f74-43a1-8781-bcdf340f9ee9}

        RSS Icon
        1.0.6
        false
        kitsuneymg@gmail.com

        ShareMeNot
        1.11
        false
        sharemenot@franziroesner.com

        Siphon - Sync Add-ons
        0.9.8
        false
        siphon@siphon.ian-halpern.com

        Status-4-Evar
        2012.02.28.00b
        false
        status4evar@caligonstudios.com

        Stylish
        1.2.6
        false
        {46551EC9-40F0-4e47-8E18-8E5CF550CFB8}

        Telekom YouTube Turbo
        1.0.1
        false
        info@maltegoetz.de

        Test Pilot
        1.2
        false
        testpilot@labs.mozilla.com

        United States English Spellchecker
        5.0.1
        false
        en-US@dictionaries.addons.mozilla.org

        vshare Add-On
        1.21
        false
        {dd05fd3d-18df-4ce4-ae53-e795339c5f01}

        Wörterbuch Deutsch (de-DE), Hunspell-unterstützt
        20120211
        false
        de_DE@dicts.j3e.de

  Wichtige modifizierte Einstellungen

      Name

      Wert

        accessibility.typeaheadfind.flashBar
        0

        browser.cache.disk.capacity
        0

        browser.cache.disk.enable
        false

        browser.cache.disk.smart_size.enabled
        false

        browser.cache.disk.smart_size.first_run
        false

        browser.cache.disk.smart_size_cached_value
        0

        browser.cache.memory.enable
        false

        browser.cache.memory.max_entry_size
        1

        browser.history_expire_days.mirror
        180

        browser.link.open_newwindow.override.external
        1

        browser.places.importBookmarksHTML
        false

        browser.places.importDefaults
        false

        browser.places.leftPaneFolderId
        -1

        browser.places.migratePostDataAnnotations
        false

        browser.places.smartBookmarksVersion
        3

        browser.places.updateRecentTagsUri
        false

        browser.sessionstore.interval
        100000

        browser.sessionstore.max_tabs_undo
        5

        browser.sessionstore.privacy_level
        1

        browser.sessionstore.restore_on_demand
        false

        browser.sessionstore.resume_from_crash
        false

        browser.startup.homepage
        about:mozilla

        browser.startup.homepage_override.buildID
        20120309062528

        browser.startup.homepage_override.mstone
        13.0a1

        browser.tabs.animate
        false

        browser.tabs.closeWindowWithLastTab
        false

        browser.zoom.siteSpecific
        false

        extensions.checkCompatibility
        false

        extensions.checkCompatibility.10.0
        false

        extensions.checkCompatibility.10.0a
        false

        extensions.checkCompatibility.11.0
        false

        extensions.checkCompatibility.11.0a
        false

        extensions.checkCompatibility.3.6
        false

        extensions.checkCompatibility.3.6.previous
        false

        extensions.checkCompatibility.3.6b
        false

        extensions.checkCompatibility.3.6b.previous
        false

        extensions.checkCompatibility.3.6p
        false

        extensions.checkCompatibility.3.6p.previous
        false

        extensions.checkCompatibility.3.6pre
        false

        extensions.checkCompatibility.3.6pre.previous
        false

        extensions.checkCompatibility.3.7a
        false

        extensions.checkCompatibility.3.7a.previous
        false

        extensions.checkCompatibility.4.0
        false

        extensions.checkCompatibility.4.0.previous
        false

        extensions.checkCompatibility.4.0b
        false

        extensions.checkCompatibility.4.0b.previous
        false

        extensions.checkCompatibility.4.0p
        false

        extensions.checkCompatibility.4.0p.previous
        false

        extensions.checkCompatibility.4.0pre
        false

        extensions.checkCompatibility.4.0pre.previous
        false

        extensions.checkCompatibility.4.2
        false

        extensions.checkCompatibility.4.2.previous
        false

        extensions.checkCompatibility.4.2a
        false

        extensions.checkCompatibility.4.2a.previous
        false

        extensions.checkCompatibility.4.2b
        false

        extensions.checkCompatibility.4.2b.previous
        false

        extensions.checkCompatibility.4.2p
        false

        extensions.checkCompatibility.4.2p.previous
        false

        extensions.checkCompatibility.4.2pre
        false

        extensions.checkCompatibility.4.2pre.previous
        false

        extensions.checkCompatibility.5.0
        false

        extensions.checkCompatibility.5.0.previous
        false

        extensions.checkCompatibility.5.0a
        false

        extensions.checkCompatibility.5.0a.previous
        false

        extensions.checkCompatibility.5.0b
        false

        extensions.checkCompatibility.5.0b.previous
        false

        extensions.checkCompatibility.5.0p
        false

        extensions.checkCompatibility.5.0p.previous
        false

        extensions.checkCompatibility.5.0pre
        false

        extensions.checkCompatibility.5.0pre.previous
        false

        extensions.checkCompatibility.6.0
        false

        extensions.checkCompatibility.6.0.previous
        false

        extensions.checkCompatibility.6.0a
        false

        extensions.checkCompatibility.6.0a.previous
        false

        extensions.checkCompatibility.7.0
        false

        extensions.checkCompatibility.7.0.previous
        false

        extensions.checkCompatibility.7.0a
        false

        extensions.checkCompatibility.7.0a.previous
        false

        extensions.checkCompatibility.8.0
        false

        extensions.checkCompatibility.8.0.previous
        false

        extensions.checkCompatibility.8.0a
        false

        extensions.checkCompatibility.8.0a.previous
        false

        extensions.checkCompatibility.9.0
        false

        extensions.checkCompatibility.9.0a
        false

        extensions.checkCompatibility.nightly
        false

        extensions.checkCompatibility.nightly.previous
        true

        extensions.checkCompatibility.previous
        false

        extensions.lastAppVersion
        13.0a1

        general.autoScroll
        false

        general.useragent.extra.microsoftdotnet
        (.NET CLR 3.5.30729)

        gfx.3d_video.enabled
        true

        gfx.direct3d.prefer_10_1
        true

        gfx.font_rendering.cleartype.always_use_for_content
        true

        gfx.use_text_smoothing_setting
        true

        keyword.URL
        http://www.google.com/search?ie=UTF-8&oe=UTF-8&q=

        layers.accelerate-all
        true

        network.buffer.cache.size
        3276

        network.cookie.prefsMigrated
        true

        network.http.pipelining
        true

        network.http.pipelining.maxrequests
        8

        places.database.lastMaintenance
        1331317209

        places.history.expiration.transient_current_max_pages
        104858

        places.history.expiration.transient_optimal_database_size
        167772160

        places.last_vacuum
        1270190442

        print.print_printer
        hp deskjet 5550 series (HPA)

        print.printer_hp_deskjet_5550_series_(HPA).print_bgcolor
        false

        print.printer_hp_deskjet_5550_series_(HPA).print_bgimages
        false

        print.printer_hp_deskjet_5550_series_(HPA).print_command

        print.printer_hp_deskjet_5550_series_(HPA).print_downloadfonts
        false

        print.printer_hp_deskjet_5550_series_(HPA).print_edge_bottom
        0

        print.printer_hp_deskjet_5550_series_(HPA).print_edge_left
        0

        print.printer_hp_deskjet_5550_series_(HPA).print_edge_right
        0

        print.printer_hp_deskjet_5550_series_(HPA).print_edge_top
        0

        print.printer_hp_deskjet_5550_series_(HPA).print_evenpages
        true

        print.printer_hp_deskjet_5550_series_(HPA).print_footercenter

        print.printer_hp_deskjet_5550_series_(HPA).print_footerleft
        &PT

        print.printer_hp_deskjet_5550_series_(HPA).print_footerright
        &D

        print.printer_hp_deskjet_5550_series_(HPA).print_headercenter

        print.printer_hp_deskjet_5550_series_(HPA).print_headerleft
        &T

        print.printer_hp_deskjet_5550_series_(HPA).print_headerright
        &U

        print.printer_hp_deskjet_5550_series_(HPA).print_in_color
        true

        print.printer_hp_deskjet_5550_series_(HPA).print_margin_bottom
        0.5

        print.printer_hp_deskjet_5550_series_(HPA).print_margin_left
        0.5

        print.printer_hp_deskjet_5550_series_(HPA).print_margin_right
        0.5

        print.printer_hp_deskjet_5550_series_(HPA).print_margin_top
        0.5

        print.printer_hp_deskjet_5550_series_(HPA).print_oddpages
        true

        print.printer_hp_deskjet_5550_series_(HPA).print_orientation
        0

        print.printer_hp_deskjet_5550_series_(HPA).print_page_delay
        50

        print.printer_hp_deskjet_5550_series_(HPA).print_paper_data
        9

        print.printer_hp_deskjet_5550_series_(HPA).print_paper_height
        11,00

        print.printer_hp_deskjet_5550_series_(HPA).print_paper_size_type
        0

        print.printer_hp_deskjet_5550_series_(HPA).print_paper_size_unit
        1

        print.printer_hp_deskjet_5550_series_(HPA).print_paper_width
        8,50

        print.printer_hp_deskjet_5550_series_(HPA).print_reversed
        false

        print.printer_hp_deskjet_5550_series_(HPA).print_scaling
        1,00

        print.printer_hp_deskjet_5550_series_(HPA).print_shrink_to_fit
        true

        print.printer_hp_deskjet_5550_series_(HPA).print_to_file
        false

        print.printer_hp_deskjet_5550_series_(HPA).print_unwriteable_margin_bottom
        0

        print.printer_hp_deskjet_5550_series_(HPA).print_unwriteable_margin_left
        0

        print.printer_hp_deskjet_5550_series_(HPA).print_unwriteable_margin_right
        0

        print.printer_hp_deskjet_5550_series_(HPA).print_unwriteable_margin_top
        0

        privacy.clearOnShutdown.cookies
        false

        privacy.clearOnShutdown.formdata
        false

        privacy.clearOnShutdown.history
        false

        privacy.clearOnShutdown.sessions
        false

        privacy.cpd.siteSettings
        true

        privacy.donottrackheader.enabled
        true

        privacy.sanitize.migrateFx3Prefs
        true

        privacy.sanitize.timeSpan
        0

        security.dialog_enable_delay
        0

        security.warn_viewing_mixed
        false

  Grafik

        Karten-Beschreibung
        ATI Radeon HD 5700 Series

        Vendor-ID
        0x1002

        Geräte-ID
        0x68b8

        Karten-RAM
        1024

        Karten-Treiber
        aticfx64 aticfx64 aticfx64 aticfx32 aticfx32 aticfx32 atiumd64 atidxx64 atidxx64 atiumdag atidxx32 atidxx32 atiumdva atiumd6a atitmm64

        Treiber-Version
        8.950.0.0

        Treiber-Datum
        2-14-2012

        Direct2D aktiviert
        true

        DirectWrite aktiviert
        true (6.1.7601.21865)

        ClearType-Parameter
        Gamma: 2200 Pixel Structure: RGB ClearType Level: 100 Enhanced Contrast: 300

        WebGL-Renderer
        Google Inc. -- ANGLE (ATI Radeon HD 5700 Series) -- OpenGL ES 2.0 (ANGLE 1.0.0.963)

        GPU-beschleunigte Fenster
        1/1 Direct3D 10

        AzureBackend
        direct2d

  JavaScript

        Inkrementelle GC
        1
Comment 6 Nicholas Nethercote [:njn] 2012-03-09 13:33:19 PST
(In reply to André Ziegler from comment #4)
> it still doesn't include anything useful:
> 
> Zeitstempel: 09.03.2012 19:35:02
> Fehler: uncaught exception: aboutMemory.js assertion failed: Unknown
> location: 

It is useful -- it says that document.title is empty.  As for how that happens, I have no idea.

I see you have multiple add-ons present.  Can you try restarting in safe mode (which disables add-ons) and see if the problem still occurs?  That would be helpful for debugging purposes.
Comment 7 André Ziegler 2012-03-09 15:41:57 PST
I'm using a portable version with the loader from caschy (ftp://ftp.hosteurope.de/mirror/stadt-bremerhaven.de/Portable_Firefox/). Any ideas how I can start this in safe mode?
Comment 8 Nicholas Nethercote [:njn] 2012-03-09 17:46:30 PST
(In reply to André Ziegler from comment #7)
> I'm using a portable version with the loader from caschy
> (ftp://ftp.hosteurope.de/mirror/stadt-bremerhaven.de/Portable_Firefox/). Any
> ideas how I can start this in safe mode?

Do the normal instructions (http://support.mozilla.org/en-US/kb/Safe%20Mode) work?  If not, I have no idea, sorry :(
Comment 9 André Ziegler 2012-03-10 05:12:05 PST
I think it is the addon "Linkification". Disabling it restores about:memory. Can you confirm this? Does the addon also breaks about:memory for you?

http://yellow5.us/firefox/linkification/

I'm using this addon for years and can't live without it. And last week nighly works and I saw the issue this week after getting some new l10n updates (after the bug was fixed which caused the l10n builds fail to compile).
Comment 10 Justin Lebar (not reading bugmail) 2012-03-10 11:09:01 PST
> I think it is the addon "Linkification". Disabling it restores about:memory.

It's probably messing with the DOM -- about:memory makes a number of assumptions about the specific DOM structure of the page and will break if an extension swoops in and modifies the page.

Linkification could easily fix this by adding about:memory to a blacklist and never modifying its contents.

I can't find contact information for the add-on developer, John Hansen (y5).  Jorge, do you have an e-mail address?

https://addons.mozilla.org/en-US/firefox/user/123/
Comment 11 Nicholas Nethercote [:njn] 2012-03-11 13:55:32 PDT
(In reply to Justin Lebar [:jlebar] from comment #10)
> > I think it is the addon "Linkification". Disabling it restores about:memory.
> 
> It's probably messing with the DOM -- about:memory makes a number of
> assumptions about the specific DOM structure of the page and will break if
> an extension swoops in and modifies the page.

There is one assumption.  about:memory sets |document.title| early on and then a short time later looks at it again.  Linkification must be changing |document.title| between these two points.  about:memory assumes that change can't happen.

Is that assumption reasonable?  I thought that relying on |document.title| not changing was reasonable, but my webdev skills are poor.

An easy fix would be for about:memory to store a copy of |document.title| in a local variable and then check that during the second step.
Comment 12 Justin Lebar (not reading bugmail) 2012-03-11 13:58:02 PDT
> Is that assumption reasonable?

In my uninformed opinion, yes, I think that's reasonable, particularly for an about: page.
Comment 13 André Ziegler 2012-03-18 15:59:41 PDT
(In reply to Justin Lebar [:jlebar] from comment #10)
> I can't find contact information for the add-on developer, John Hansen (y5).
> Jorge, do you have an e-mail address?
> 
> https://addons.mozilla.org/en-US/firefox/user/123/

I wrote him to this address, but no reply:

http://whois.domaintools.com/yellow5.us
Comment 14 André Ziegler 2012-04-22 10:49:52 PDT
I've stopped using Linkification because of this issue and the lack of response from the developer.

I'm now using the Linkify Plus GM script:

http://userscripts.org/scripts/show/1352
Comment 15 Gingerbread Man 2012-05-14 21:44:18 PDT
(In reply to André Ziegler from comment #14)
> I've stopped using Linkification because of this issue

It's trivial to adjust preferences to fix this though.

Method #1: Ignore all about: pages.
1. Open Linkification Options either by right-clicking the status bar icon and choosing Options, or from the Add-ons Manager.
2. Click the Advanced tab.
3. From the "Text Protocol:Link Protocol" box, delete the following:
about:about!,
4. Click the OK button.

Method #2: Auto-linkify whitelisted sites only
1. Open Linkification Options either by right-clicking the status bar icon and choosing Options, or from the Add-ons Manager.
2. Click the Functionality tab.
3. Check "Only Auto-Linkify the following domains" and specify them below.
4. Click the OK button.

Note You need to log in before you can comment on or make changes to this bug.