Note: There are a few cases of duplicates in user autocompletion which are being worked on.

GCLI resource doesn't always find script tags

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Developer Tools: Console
P3
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jwalker, Assigned: jwalker)

Tracking

unspecified
Firefox 15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment)

>>> document.body.querySelectorAll("script");
undefined

>>> document.body.getElementsByTagName("script");
undefined

>>> document.body.children[5];
<script src="scripts/require.js" type="text/javascript">
GCLI Triage.
Target Milestone: Firefox 14 → Firefox 15
Blocks: 745773
Created attachment 628648 [details] [diff] [review]
Upload 1

Turns out this was a test failure.
This is trivial enough that I'm not going to bother with a pull request.

But for your delectation, the commit message:

    Bug 734045 (script0): Use getLookup not getPredictions
    
    The results of getPredictions are filtered through the matcher which
    prevents the return of more than 10 results, so it's silly doing maths on
    the lengths expecting it to work. Instead we should be using getLookup
    directly which isn't filtered, and so the length maths will work.
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Attachment #628648 - Flags: review?(dcamp)

Updated

5 years ago
Attachment #628648 - Flags: review?(dcamp) → review+
https://tbpl.mozilla.org/?tree=Fx-Team&rev=c9b7a566ff05
Whiteboard: [fixed-in-fx-team]
(Also fwiw: https://tbpl.mozilla.org/?tree=Try&rev=3e09d6ee6d89)

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/c9b7a566ff05
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.