Closed
Bug 734045
Opened 12 years ago
Closed 12 years ago
GCLI resource doesn't always find script tags
Categories
(DevTools :: Console, defect, P3)
DevTools
Console
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 15
People
(Reporter: jwalker, Assigned: jwalker)
References
Details
(Whiteboard: [fixed-in-fx-team])
Attachments
(1 file)
2.46 KB,
patch
|
dcamp
:
review+
|
Details | Diff | Splinter Review |
>>> document.body.querySelectorAll("script"); undefined >>> document.body.getElementsByTagName("script"); undefined >>> document.body.children[5]; <script src="scripts/require.js" type="text/javascript">
Assignee | ||
Comment 2•12 years ago
|
||
Turns out this was a test failure. This is trivial enough that I'm not going to bother with a pull request. But for your delectation, the commit message: Bug 734045 (script0): Use getLookup not getPredictions The results of getPredictions are filtered through the matcher which prevents the return of more than 10 results, so it's silly doing maths on the lengths expecting it to work. Instead we should be using getLookup directly which isn't filtered, and so the length maths will work.
Updated•12 years ago
|
Attachment #628648 -
Flags: review?(dcamp) → review+
Assignee | ||
Comment 3•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Fx-Team&rev=c9b7a566ff05
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Comment 4•12 years ago
|
||
(Also fwiw: https://tbpl.mozilla.org/?tree=Try&rev=3e09d6ee6d89)
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c9b7a566ff05
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•