734081 - Check pixel depth when choosing config on egl

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Michael Wu [:mwu]]

Attachment: Check pixel depth when choosing config on egl

Turns out the Nexus S gets upset when we try to use 16bit surfaces on B2G.

Android is fixed at 16bit but I think they all support 16bit anyway. I can switch to proper detection if someone finds a way to do it. However, the docs say: "By default GLSurfaceView chooses a EGLConfig that has an RGB_565 pixel format, with at least a 16-bit depth buffer and no stencil." so we should be ok forcing 16bit.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 604063 [details] [diff] [review]
Check pixel depth when choosing config on egl

>diff --git a/gfx/gl/GLContextProviderEGL.cpp b/gfx/gl/GLContextProviderEGL.cpp

>+    nsCOMPtr<nsIScreenManager> screenMgr = do_GetService("@mozilla.org/gfx/screenmanager;1");
>+    nsCOMPtr<nsIScreen> screen;
>+    screenMgr->GetPrimaryScreen(getter_AddRefs(screen));
>+    PRInt32 depth = 24;
>+    screen->GetColorDepth(&depth);
> 

Yay XPCOM!

Does this work on akami/maguro?

Comment 2

[Michael Wu [:mwu]]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #1)
> Yay XPCOM!
> 

:(

> Does this work on akami/maguro?

Yeah I checked and my akami picks a 16bit surface.

Comment 3

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2175db811fad

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Backed out due to Android reftest failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0b4c4897e0e

Comment 5

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d5222ee0a6dc

Offending reftest disabled on Android.

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/d5222ee0a6dc