Add balrog database admin form base class

RESOLVED FIXED

Status

Release Engineering
General
RESOLVED FIXED
6 years ago
2 months ago

People

(Reporter: edransch, Assigned: edransch)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
All forms which allow database queries will need the data_version field.

We should have a Base Class for all such forms which contains only that field. It can then be extended for any desired functionality.
(Assignee)

Comment 1

6 years ago
Created attachment 604130 [details] [diff] [review]
base class for form that edit database

Add new class which contains the hidden data-version field used for database edits.
All forms which allow database modifications should inherit from this.
Attachment #604130 - Flags: review?(bhearsum)
Comment on attachment 604130 [details] [diff] [review]
base class for form that edit database

Review of attachment 604130 [details] [diff] [review]:
-----------------------------------------------------------------

::: auslib/web/views/forms.py
@@ +35,5 @@
>          else:
>              log.debug('JSONTextField: No value list, setting self.data to {}')
>              self.data = {}
>  
> +class DbEditForm(Form):

Minor name quibble: EditableForm. Can you change that on your github branch? No need to repost.
Attachment #604130 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 605894 [details] [diff] [review]
base class for form that edits database

Updated to address feedback
Attachment #604130 - Attachment is obsolete: true
Attachment #605894 - Flags: review?(bhearsum)
Attachment #605894 - Flags: review?(bhearsum) → review+
(Assignee)

Updated

6 years ago
Blocks: 734398
(Assignee)

Comment 4

6 years ago
Created attachment 608829 [details] [diff] [review]
Add base class for DB edit forms

The patch that was attached was invalid. This one should apply cleanly.
Attachment #605894 - Attachment is obsolete: true
Attachment #608829 - Flags: review?(bhearsum)
Comment on attachment 608829 [details] [diff] [review]
Add base class for DB edit forms

Review of attachment 608829 [details] [diff] [review]:
-----------------------------------------------------------------

Landed this, Jenkins run is here: https://jenkins.mozilla.org/job/Balrog/57/
Attachment #608829 - Flags: review?(bhearsum)
Attachment #608829 - Flags: review+
Attachment #608829 - Flags: checked-in+
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.