734099 - Rewrite priorityjobs service

Status: VERIFIED FIXED

(Socorro Graveyard :: Middleware, defect)

Description

[[DEACTIVATED] Adrian Gaudebert]

File is webapp-php/application/models/priorityjobs.php.

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

I think I'm done working on this bug, but I am stuck now on how to QA it. I have unit tests that work, but I'd like to find steps for anyone to reproduce in a VM or on dev/stage. Brandon, do you have a suggestion?

Comment 2

[Brandon Savage [:brandon]]

The method Rob and I used to QA it last time was to stop the processors. This way, anything you put into the priority queue isn't picked up. Then, you can call the service externally and test it, and check the results in the queue table.

Comment 3

[[DEACTIVATED] Adrian Gaudebert]

Pull request: https://github.com/mozilla/socorro/pull/468

Steps to QA
-----------

1. Stop the processors
2. Send a new crash report into Socorro
3. Empty the priorityjobs table in PostgreSQL
4. Try to hit report/index for the uuid of the recently sent crash report
5. Verify that this uuid was added to the priorityjobs list in PostgreSQL.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/06d99360318d47bbb01e3c5ff43b14972aca8372
Fixes bug 734099 - Rewrote priorityjobs middleware service.

https://github.com/mozilla/socorro/commit/f2f2ad3f5f788d9a212647d7a5d62a4bb4c66ca7
Merge pull request #468 from AdrianGaudebert/734099-priority-jobs-service

Fixes bug 734099 - Rewrote priorityjobs middleware service.

Comment 5

[[DEACTIVATED] Adrian Gaudebert]

There is a bug in the way I instantiate the Priorityjobs class from the getCrash service. Surprisingly that exception was caught and never made it to logs, which explains why it took so long to find it... Will send a bug fix in a few minutes.

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/e52314c59b1df961acc03b11f5847fcff8aabe20
Fixes bug 734099 - Instantiated the Priorityjobs class as it should be.

https://github.com/mozilla/socorro/commit/489796ae5953343e919da160cd7be4b820b95e9f
Merge pull request #494 from AdrianGaudebert/734099-priority-jobs-service

Fixes bug 734099 - Instantiated the Priorityjobs class as it should be.

Comment 7

[[github robot]]

Commit pushed to stage at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/39d8663b8a6ce7702140752d48b9dd6bcabed087
Fixes bug 734099 - Instantiated the Priorityjobs class as it should be.

Comment 8

[Matt Brandt [:mbrandt]]

Bumping to verified on stage: thx adrian and mpressman for testifying and getting this verified.

09:46 adrian: mbrandt: I am going to send a crash that will not get processed (because it has an unknown product)
09:46 adrian: mbrandt: then you will try to hit that crash via the UI
09:46 mrmiller: ted: okay, I think that's what I'm going to do on my end then... I don't think we're going to be getting that many logs anyhow
09:46 adrian: mbrandt: that will insert that crash in the priorityjobs queue and show you a "pending" page
09:53 adrian: mbrandt: then it gets processed, and then you can see details about that crash in the UI
09:54 mbrandt: adrian: thanks - I just wanted to make sure the model in my brain was correct :)
09:54 mbrandt often times its not
09:54 ted: mrmiller: definitely interested to hear your results
09:54 adrian: mbrandt: priorityjobs is a queue that processors watch, and as its name says, they get processed faster.
please try to access https://crash-stats.allizom.org/report/index/5d17e718-6767-46ad-93d3-1f2932120411

09:48 adrian: mbrandt: mpressman: SUCCESS