734120 - Move frequency SQL query from common model to middleware

Status: VERIFIED FIXED

(Socorro Graveyard :: Middleware, defect)

Description

[[DEACTIVATED] Adrian Gaudebert]

In webapp-php/application/models/common.php there is a last SQL query for crash frequency. When it is removed and replace by a middleware service, the _buildCriteriaFromSearchParams() function can at last be removed.

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

Pull request: https://github.com/mozilla/socorro/pull/482

Steps to QA
-----------

1. Go to topcrashers or search, click a signature to go to report/list
2. Load the same report/list page on prod
3. Compare the Graph and Table tabs: they should match. 
4. Try with different products/versions and different signatures.

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/40f91bf03ba316b1640d98a655773cc282108ecf
Fixes bug 734120 - Moved crash fequency query to a new middleware service.

https://github.com/mozilla/socorro/commit/865dbe2bd5084b59cf622e68e84144756cea433f
Merge pull request #482 from AdrianGaudebert/734120-crash-frequency-service

Fixes bug 734120 - Moved crash fequency query to a new middleware service.

Comment 3

[Matt Brandt [:mbrandt]]

Thank you adrian for the wicked-awesome comment 1:
QA verified - note I had to bump the date range back on the queries to make sure the data (from the last dmp) was consistent on stage and prod.

Tables and Graphs match for all products - I selected signatures at random.

Example queries:

https://crash-stats.allizom.org/report/list?range_value=7&range_unit=days&date=2012-04-01&signature=JNI_GetCreatedJavaVMs&version=FennecAndroid%3A14.0a1

https://crash-stats.mozilla.com/report/list?range_value=7&range_unit=days&date=2012-04-01&signature=JNI_GetCreatedJavaVMs&version=FennecAndroid%3A14.0a1

https://crash-stats.allizom.org/report/list?range_value=7&range_unit=days&date=2012-04-01&signature=nsFileOutputStream%3A%3AWrite%28char%20const*%2C%20unsigned%20int%2C%20unsigned%20int*%29&version=Thunderbird%3A11.0

https://crash-stats.mozilla.com/report/list?range_value=7&range_unit=days&date=2012-04-01&signature=nsFileOutputStream%3A%3AWrite%28char%20const*%2C%20unsigned%20int%2C%20unsigned%20int*%29&version=Thunderbird%3A11.0

Comment 4

[[github robot]]

Commits pushed to processor2012 at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/40f91bf03ba316b1640d98a655773cc282108ecf
Fixes bug 734120 - Moved crash fequency query to a new middleware service.

https://github.com/mozilla/socorro/commit/865dbe2bd5084b59cf622e68e84144756cea433f
Merge pull request #482 from AdrianGaudebert/734120-crash-frequency-service