Closed Bug 734135 Opened 8 years ago Closed 8 years ago

When drawing an unlocked image, move it to the back of the discard queue

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

Details

Attachments

(1 file)

On Fennec, we never lock images (bug 734089).  So in particular, we can draw unlocked images.

When an image is Draw'n we should tell the discard tracker to move the image to the back of the discard queue, so it's less likely that we'll throw away an image we just drew.
Assignee: nobody → justin.lebar+bug
Attached patch Patch v1Splinter Review
Attachment #604094 - Flags: review?(joe)
Comment on attachment 604094 [details] [diff] [review]
Patch v1

Review of attachment 604094 [details] [diff] [review]:
-----------------------------------------------------------------

::: image/src/RasterImage.cpp
@@ +2582,5 @@
> +  // If this image is a candidate for discarding, reset its position in the
> +  // discard tracker so we're less likely to discard it right away.
> +  //
> +  // (We don't normally draw unlocked images, so this conditition will usually
> +  // be false.  active.  But we will draw unlocked images if image locking is

stray "active."
Attachment #604094 - Flags: review?(joe) → review+
https://hg.mozilla.org/mozilla-central/rev/ada07a6d6264
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.