734181 - [B2G] SMS database: filter with `endDate` but no `startDate` parameter throws an exception

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

The following test:

let filter = new MozSmsFilter();
filter.endDate = new Date(1329999861799);
gSmsDatabaseService.createMessageList(filter, false, 11);

throws this exception:

ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/sms/tests/test_smsdatabaseservice.xul | an unexpected uncaught JS exception reported through window.onerror - uncaught exception: [Exception... "'[JavaScript Error: "filter.startDate is null" {file: "file:///Volumes/Data/dev/mozilla/mozilla-central-hg/obj-firefox/dist/Nightly.app/Contents/MacOS/components/SmsDatabaseService.js" line: 491}]' when calling method: [nsISmsDatabaseService::createMessageList]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://mochitests/content/chrome/dom/sms/tests/test_smsdatabaseservice.xul :: test_createMessageList_endDate_filter_success :: line 401"  data: yes] at :0

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Fix v1

Here it goes the fix.

Comment 2

[Philipp von Weitershausen [:philikon]]

Comment on attachment 604119 [details] [diff] [review]
Fix v1

Ouch... :)

Looks like you discovered this while writing tests, so I won't even ask for them. Goooo tests! :)

Comment 3

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/mozilla-central/rev/db2954a4c62f