734299 - B2G 3G: Bring up a data call when registering with the network

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Philipp von Weitershausen [:philikon]]

Ultimately, the Network Manager (bug 717122) will manage network connections and unify some of the Wifi and 3G code. But mrbkap is still hacking on Wifi, and we want 3G to work in the mean time, so here's the 3G-only pieces carved out of bug 717122.

This also reduces bug 717122 to simply unifying the code and implementing the Network Manager switchover logic. Smaller bugs FTW.

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: Part 1 (v1): Detect a datacall quirk on the SGS2

Yay more quirks in the Samsung RIL...

Comment 2

[Philipp von Weitershausen [:philikon]]

Attachment: Part 2 (v1): Worker code for network configuration

This is straight up from bug 717122 part 2, which cjones already r+'ed, just without any of the Network Manager component bits.

Comment 3

[Philipp von Weitershausen [:philikon]]

Attachment: Part 3 (v1): Set up datacall

This will bring up a datacall when we successfully register with the network. But only if you set the "ril.data.enabled" pref in Gecko to true.

This short-circuits to the network worker in part 2. Once we get the Network Manager, that will change, of course. It will be in control of all network config.

Comment 4

[Philipp von Weitershausen [:philikon]]

Comment on attachment 604278 [details] [diff] [review]
Part 3 (v1): Set up datacall

(Note that this patch applies on top of bug 734300...)

Comment 5

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 604276 [details] [diff] [review]
Part 1 (v1): Detect a datacall quirk on the SGS2

Review of attachment 604276 [details] [diff] [review]:
-----------------------------------------------------------------

Sad that we need it, but looks good. r=me

Comment 6

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/mozilla-central/rev/3463e63451a4
https://hg.mozilla.org/mozilla-central/rev/f92e3e6f93a7
https://hg.mozilla.org/mozilla-central/rev/170757be69f3