Closed Bug 734306 Opened 11 years ago Closed 11 years ago

nsNPAPIPluginInstance.cpp:1491:10: warning: implicit conversion from 'nsresult' (aka 'unsigned int') to 'NPError' (aka 'short') changes value from 2147500037 to 16389 (also line 1500)

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla13

People

(Reporter: Waldo, Assigned: jaas)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

fix v1.0
1.85 KB, patch
bas.schouten
: review+
Details | Diff | Splinter Review 
NPError
nsNPAPIPluginInstance::InitAsyncSurface(NPSize *size, NPImageFormat format,
                                        void *initData, NPAsyncSurface *surface)
{
  if (mOwner)
    return mOwner->InitAsyncSurface(size, format, initData, surface);

  return NS_ERROR_FAILURE;
}

NPError
nsNPAPIPluginInstance::FinalizeAsyncSurface(NPAsyncSurface *surface)
{
  if (mOwner)
    return mOwner->FinalizeAsyncSurface(surface);

  return NS_ERROR_FAILURE;
}

We're defining a method that returns NPError, then returning an nsresult from it.  Clearly a bug, no idea what the consequences are.  (And <3 clang for pointing it out so nicely, including with the truncated value parts.)
Assignee: nobody → joshmoz
Summary: nsNPAPIPluginInstance.cpp:1491:10: warning: implicit conversion from 'nsresult' (aka 'unsigned int') to 'NPError' (aka 'short') changes value from 2147500037 to 16389 (also line 1500 → nsNPAPIPluginInstance.cpp:1491:10: warning: implicit conversion from 'nsresult' (aka 'unsigned int') to 'NPError' (aka 'short') changes value from 2147500037 to 16389 (also line 1500)
I think this probably landed with Bas's async NPAPI implementation.
Attached patch fix v1.0 — — Splinter Review 

        Attachment #604454 -
        Flags: review?(bas.schouten)

    
    

    
  
Comment on attachment 604454 [details] [diff] [review]
fix v1.0

Review of attachment 604454 [details] [diff] [review]:
-----------------------------------------------------------------

I doubt there's significant consequences! But this is a good change!

        Attachment #604454 -
        Flags: review?(bas.schouten) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/de4b5d7ba0e5
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13

    
  
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.