734333 - typo in RIL.iccIO() throws ReferenceError: request is not defined

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

I/Gecko   ( 2621): RIL Worker: Parcel handling threw ReferenceError: request is not defined
I/Gecko   ( 2621): iccIO([object Object])@resource://gre/modules/ril_worker.js:944
I/Gecko   ( 2621): getMSISDN()@resource://gre/modules/ril_worker.js:2244
I/Gecko   ( 2621): onRadioStateChanged(4)@resource://gre/modules/ril_worker.js:1525
I/Gecko   ( 2621): UNSOLICITED_RESPONSE_RADIO_STATE_CHANGED(4,(void 0))@resource://gre/modules/ril_worker.js:1295
I/Gecko   ( 2621): handleParcel(1000,4,(void 0))@resource://gre/modules/ril_worker.js:999
I/Gecko   ( 2621): processParcel()@resource://gre/modules/ril_worker.js:490
I/Gecko   ( 2621): processIncoming([object Uint8Array])@resource://gre/modules/ril_worker.js:433
I/Gecko   ( 2621): onRILMessage([object Uint8Array])@resource://gre/modules/ril_worker.js:3216

and change https://hg.mozilla.org/mozilla-central/rev/36c4724de5bf, patch chunk 2, line 41:

2.41 +    if (request.pin2 != null) {
2.42 +      Buf.writeString(pin2);
2.43 +    }

`request` should be `options`.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: patch

fix typo

Comment 2

[Philipp von Weitershausen [:philikon]]

Comment on attachment 604321 [details] [diff] [review]
patch

Review of attachment 604321 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for introducing the typo and many thanks for fixing it, Yoshi!

Comment 3

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/mozilla-central/rev/170757be69f3

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

No worries,
it should be my fault that didn't notice this in the first place,
thank you and also thanks Vicamo discovered this. :)