Closed Bug 734375 Opened 9 years ago Closed 9 years ago

Support Attachments and Attendees on Alarms

Categories

(Calendar :: Alarms, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch Fix - v1 β€” β€” Splinter Review
This patch supports adding attachments and attendees to alarms, which is needed for supporting real EMAIL and AUDIO alarms. I haven't implemented a strict check for attachments on EMAIL alarms, since that might break things. We can still do that when its needed.
Attachment #604400 - Flags: review?(matthew.mecca)
Summary: Support Attachments and Attendees → Support Attachments and Attendees on Alarms
Comment on attachment 604400 [details] [diff] [review]
Fix - v1

Review of attachment 604400 [details] [diff] [review]:
-----------------------------------------------------------------

looks good. r=mmecca

::: calendar/base/public/calIAlarm.idl
@@ +149,5 @@
> +     void addAttendee(in calIAttendee aAttendee);
> +     void deleteAttendee(in calIAttendee aAttendee);
> +     void clearAttendees();
> +     void getAttendees(out PRUint32 count,
> +                         [array,size_is(count),retval] out calIAttendee attendees);

minor nit: line is indented 2 extra spaces
Attachment #604400 - Flags: review?(matthew.mecca) → review+
Pushed to comm-central changeset eb1745fc8a71
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.