734416 - [Traceback] UndefinedError for ACR Reports from Conkeror(?)

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Compatibility Tools, defect)

Description

[Christopher Van Wiemeersch [:cvan]]

Traceback (most recent call last):

 File "/data/www/addons.mozilla.org/zamboni/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/www/addons.mozilla.org/zamboni/apps/compat/views.py", line 185, in reporter_detail
   name=name, guid=guid, form=form))

 File "/data/www/addons.mozilla.org/zamboni/vendor/src/jingo/jingo/__init__.py", line 80, in render
   rendered = render_to_string(request, template, context)

 File "/data/www/addons.mozilla.org/zamboni/vendor/src/jingo/jingo/__init__.py", line 98, in render_to_string
   return template.render(**get_context())

 File "/usr/lib64/python2.6/site-packages/jinja2/environment.py", line 891, in render
   return self.environment.handle_exception(exc_info, True)

 File "/data/www/addons.mozilla.org/zamboni/apps/compat/templates/compat/reporter_detail.html", line 1, in top-level template code
   {% extends "impala/base_shared.html" %}

 File "/data/www/addons.mozilla.org/zamboni/templates/impala/base_shared.html", line 4, in top-level template code
   {% extends "webapps/base.html" if WEBAPPS else "impala/base.html" %}

 File "/data/www/addons.mozilla.org/zamboni/templates/impala/base.html", line 182, in top-level template code
   {% block main_content %}

 File "/data/www/addons.mozilla.org/zamboni/templates/impala/base.html", line 187, in block "main_content"
   {% block content %}{% endblock %}

 File "/data/www/addons.mozilla.org/zamboni/apps/compat/templates/compat/reporter_detail.html", line 58, in block "content"
   <td>{{ amo.APP_GUIDS[report.app_guid].pretty }} {{ report.app_version }}</td>

 File "/usr/lib64/python2.6/site-packages/jinja2/environment.py", line 371, in getattr
   return getattr(obj, attribute)

UndefinedError: 'dict object' has no attribute u'{a79fe89b-6662-4ff4-8e88-09950ad4dfde}'

http://arecibo1.dmz.phx1.mozilla.com/view/1660199/

Comment 1

[Gregory Koberger (:gkoberger)]

Conkeror is a browser based on Mozilla that can be operated with only the keyboard. So, it supports our add-ons without being in our system.

I don't want to support Conkeror, but I can see this being a problem with this and other Firefox forks.

What about something like this? (psuedocode!)

def getApp(guid):
  if guid in amo.APP_GUIDS:
    return amo.APP_GUIDS[guid]
  else:
    return amo.APP_UNKNOWN

Comment 2

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/6970828

Thanks, Gregory!