Closed Bug 734494 Opened 8 years ago Closed 6 years ago

release_sanity.py errors out on unexpected versions

Categories

(Release Engineering :: Release Automation: Other, defect, P4)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aki, Unassigned)

References

Details

(Whiteboard: [release][bumping][release-sanity])

If, per bug 734493, we are able to bump any release version to any other release version on any build number (not just build 1), then we shouldn't be getting release_sanity errors like this:

2012-03-09 12:26:00,359 : ERROR : config/milestone.txt has incorrect version '# Holds the current milestone.
# Should be in the format of
#
#    x.x.x
#    x.x.x.x
#    x.x.x+
#
# Referenced by milestone.pl.
# Hopefully I'll be able to automate replacement of *all*
# hardcoded milestones in the tree from these two files.
#--------------------------------------------------------

10.0.4esrpre
' (expected '10.0.3')
2012-03-09 12:26:06,829 : ERROR : browser/config/version.txt has incorrect version '10.0.4esrpre
' (expected '10.0.3')
2012-03-09 12:26:13,194 : ERROR : js/src/config/milestone.txt has incorrect version '# Holds the current milestone.
# Should be in the format of
#
#    x.x.x
#    x.x.x.x
#    x.x.x+
#
# Referenced by milestone.pl.
# Hopefully I'll be able to automate replacement of *all*
# hardcoded milestones in the tree from these two files.
#--------------------------------------------------------

10.0.4esrpre
' (expected '10.0.3')
sorry, isn't this what we want? release_sanity is bombing out because the version isn't correct.
If we fix tagging to bump the version, why should it error out?
Also, we explicitly set the default version to 10.0.4esrpre in the release config.
is it complaining about the version on the relbranch, or on the default branch?
build 2 was off default, so it was complaining about the version on the default branch.

My point is this: if, as we agreed, we should always be bumping the version, why should we error out when the version isn't the expected version?
Priority: -- → P4
Whiteboard: [release][bumping][release-sanity]
Bulk move of bugs to Release Automation component.
Component: Release Engineering: Automation (General) → Release Engineering: Automation (Release Automation)
Mass move of bugs to Release Automation component.
No longer blocks: hg-automation
Product: mozilla.org → Release Engineering
We killed version checking in bug 905871.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.