734494 - release_sanity.py errors out on unexpected versions

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect, P4)

Description

[Aki Sasaki (not active)]

If, per bug 734493, we are able to bump any release version to any other release version on any build number (not just build 1), then we shouldn't be getting release_sanity errors like this:

2012-03-09 12:26:00,359 : ERROR : config/milestone.txt has incorrect version '# Holds the current milestone.
# Should be in the format of
#
#    x.x.x
#    x.x.x.x
#    x.x.x+
#
# Referenced by milestone.pl.
# Hopefully I'll be able to automate replacement of *all*
# hardcoded milestones in the tree from these two files.
#--------------------------------------------------------

10.0.4esrpre
' (expected '10.0.3')
2012-03-09 12:26:06,829 : ERROR : browser/config/version.txt has incorrect version '10.0.4esrpre
' (expected '10.0.3')
2012-03-09 12:26:13,194 : ERROR : js/src/config/milestone.txt has incorrect version '# Holds the current milestone.
# Should be in the format of
#
#    x.x.x
#    x.x.x.x
#    x.x.x+
#
# Referenced by milestone.pl.
# Hopefully I'll be able to automate replacement of *all*
# hardcoded milestones in the tree from these two files.
#--------------------------------------------------------

10.0.4esrpre
' (expected '10.0.3')

Comment 1

[Chris AtLee [:catlee]]

sorry, isn't this what we want? release_sanity is bombing out because the version isn't correct.

Comment 2

[Aki Sasaki (not active)]

If we fix tagging to bump the version, why should it error out?
Also, we explicitly set the default version to 10.0.4esrpre in the release config.

Comment 3

[Chris AtLee [:catlee]]

is it complaining about the version on the relbranch, or on the default branch?

Comment 4

[Aki Sasaki (not active)]

build 2 was off default, so it was complaining about the version on the default branch.

My point is this: if, as we agreed, we should always be bumping the version, why should we error out when the version isn't the expected version?

Comment 5

[[e-mail] (:bhearsum)]

Bulk move of bugs to Release Automation component.

Comment 6

[[e-mail] (:bhearsum)]

Mass move of bugs to Release Automation component.

Comment 7

[[e-mail] (:bhearsum)]

We killed version checking in bug 905871.