734496 - zooming seems to be restricted by the viewport when zooming in/out near the edge of the webpage.

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[microrffr]

steps to reproduce:
1. open a webpage
2. zoom in
3. pan to corner or edge
4. pinch to zoom out. since you're at the corner or edge, the gray background stuff shows up
   - expected: zooms out at full speed
   - actual: zooms out very slowly (i.e., the zoom changes very little for the amount of pinching)

Compare without doing step 3, zooming out in the middle of the page. It zooms out at full speed.

Comment 1

[microrffr]

I looked into this some more. What I want is for this line (linked below) only to set resistance < 1 if the resisting Axis has getExcess() == BOTH.

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/ui/PanZoomController.java#794

Comment 2

[Aaron Train [:aaronmt]]

This WFM on Galaxy Nexus (4.0.2), Nightly (03/14).

Which build/device were you testing with?

Comment 3

[microrffr]

Happens on Samsung Fascinate (MIUI, based on 2.3.7), Nightly (03/14).

Comment 4

[microrffr]

I can't record a video, but here's a series of screenshots.

A1. http://i.imgur.com/ujyaH.png zoomed in at center of page, fingers at corners of viewport
A2. http://i.imgur.com/NEyGh.png after bringing fingers together
A3. http://i.imgur.com/e0deH.png after releasing

B1. http://i.imgur.com/dL0UG.png zoomed in at corner of page (after step 3 of STR), fingers at corners of viewport
B2. http://i.imgur.com/yyRYa.png after bringing fingers together
B3. http://i.imgur.com/OaSCU.png after releasing

In series B, it zooms out much less for the same amount of pinching.

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Seems to be working for me with today's build 4/9/2012 on Samsung Galaxy S II.  Could you try again with today's build please?

Comment 6

[microrffr]

It still happens for me with today's build 4/9/2012 on Samsung Fascinate.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Better late than never, right?

Comment 9

[Chris Lord [:cwiiis]]

Comment on attachment 650997 [details] [diff] [review]
Patch

Review of attachment 650997 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

Comment 10

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/506e4d2a9c02

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/506e4d2a9c02

Comment 12

[Paul Feher]

Verified using the STR from comment1 on:
Nightly 18.0a1 (2012-09-20)
Aurora 17.0a2 (2012-09-20)
Samsung Galaxy R (Android 2.3.4)