test_mailGlue_distribution.js: Services.prefs.getPref() does not exist

RESOLVED FIXED in Thunderbird 23.0

Status

Thunderbird
Build Config
--
minor
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: sgautherie, Assigned: sshagarwal)

Tracking

Trunk
Thunderbird 23.0
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Afaik, there is no getPref() in Services.prefs, is it?

http://mxr.mozilla.org/comm-central/source/mozilla/modules/libpref/public/nsIPrefBranch.idl#61
yeah we should probably just error out there.

Updated

4 years ago
Assignee: nobody → syshagarwal
Status: NEW → ASSIGNED
(Assignee)

Comment 2

4 years ago
Created attachment 745976 [details] [diff] [review]
Patch

Sir,

I have tried to make the necessary change. Please review and give feedback.
Attachment #745976 - Flags: review?(sid.bugzilla)
Attachment #745976 - Flags: review?(mconley)
Attachment #745976 - Flags: feedback?(acelists)

Comment 3

4 years ago
Comment on attachment 745976 [details] [diff] [review]
Patch

Yes, this seems fine and does what sid0 proposed.
Attachment #745976 - Flags: feedback?(acelists) → feedback+
Comment on attachment 745976 [details] [diff] [review]
Patch

Review of attachment 745976 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #745976 - Flags: review?(mconley) → review+
Attachment #745976 - Flags: review?(sid.bugzilla)
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/fbe5fc95050d
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 23.0
You need to log in before you can comment on or make changes to this bug.