Last Comment Bug 734550 - test_mailGlue_distribution.js: Services.prefs.getPref() does not exist
: test_mailGlue_distribution.js: Services.prefs.getPref() does not exist
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Build Config (show other bugs)
: Trunk
: All All
: -- minor (vote)
: Thunderbird 23.0
Assigned To: Suyash Agarwal (:sshagarwal)
:
Mentors:
http://mxr.mozilla.org/comm-central/s...
Depends on:
Blocks: 458454
  Show dependency treegraph
 
Reported: 2012-03-09 18:39 PST by Serge Gautherie (:sgautherie)
Modified: 2013-05-09 04:34 PDT (History)
5 users (show)
ryanvm: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch (1.13 KB, patch)
2013-05-06 11:37 PDT, Suyash Agarwal (:sshagarwal)
mconley: review+
acelists: feedback+
Details | Diff | Review

Description Serge Gautherie (:sgautherie) 2012-03-09 18:39:51 PST
Afaik, there is no getPref() in Services.prefs, is it?

http://mxr.mozilla.org/comm-central/source/mozilla/modules/libpref/public/nsIPrefBranch.idl#61
Comment 1 Siddharth Agarwal [:sid0] (inactive) 2012-03-09 22:48:24 PST
yeah we should probably just error out there.
Comment 2 Suyash Agarwal (:sshagarwal) 2013-05-06 11:37:15 PDT
Created attachment 745976 [details] [diff] [review]
Patch

Sir,

I have tried to make the necessary change. Please review and give feedback.
Comment 3 :aceman 2013-05-06 11:40:45 PDT
Comment on attachment 745976 [details] [diff] [review]
Patch

Yes, this seems fine and does what sid0 proposed.
Comment 4 Mike Conley (:mconley) - (Needinfo me!) 2013-05-07 07:23:20 PDT
Comment on attachment 745976 [details] [diff] [review]
Patch

Review of attachment 745976 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Comment 5 Ryan VanderMeulen [:RyanVM] 2013-05-09 04:34:42 PDT
https://hg.mozilla.org/comm-central/rev/fbe5fc95050d

Note You need to log in before you can comment on or make changes to this bug.