Add support for without-x configuration

RESOLVED FIXED in mozilla13

Status

defect
RESOLVED FIXED
7 years ago
3 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla13
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

Assignee

Description

7 years ago
I think it make sense to add support for Qt qws environment configuration, which could be enabled by --without-x configure option
Assignee

Comment 1

7 years ago
Attachment #604678 - Flags: review?(mh+mozilla)
Comment on attachment 604678 [details] [diff] [review]
Add support for without-x config option

Review of attachment 604678 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +4931,5 @@
>          AC_MSG_ERROR([You must specify a default toolkit (perhaps $_PLATFORM_DEFAULT_TOOLKIT).])
>      fi
>  
> +MOZ_ARG_WITHOUT_BOOL(x,
> +[  --without-x],

With a help message, please :)

@@ +4969,5 @@
>  cairo-qt)
>      MOZ_WIDGET_TOOLKIT=qt
>      MOZ_ENABLE_QT=1
> +    if test "$WITHOUT_X11"; then
> +        MOZ_TREE_FREETYPE=1

Is system freetype depending on X on these systems you're targetting? Wouldn't it make sense to leave it to the people building with --without-x to --enable-tree-freetype if they need to?

@@ +4970,5 @@
>      MOZ_WIDGET_TOOLKIT=qt
>      MOZ_ENABLE_QT=1
> +    if test "$WITHOUT_X11"; then
> +        MOZ_TREE_FREETYPE=1
> +        echo "Build qt without X11"

If you really want this message displayed, use AC_MSG_WARN. Otherwise remove it.
Attachment #604678 - Flags: review?(mh+mozilla) → review+
Assignee

Comment 3

7 years ago
Posted patch Fixed comments, to push (obsolete) — Splinter Review
Assignee: nobody → romaxa
Attachment #604678 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #604751 - Flags: review+
Assignee

Updated

7 years ago
Keywords: checkin-needed
You need to align the help message with the other ones. Now that I think of it, you should also AC_MSG_ERROR in case --without-x is given and MOZ_X11 is still set.
Keywords: checkin-needed
Assignee

Comment 5

7 years ago
Posted patch Add support without-x (obsolete) — Splinter Review
Is this good?
Attachment #604751 - Attachment is obsolete: true
Attachment #604754 - Flags: review?(mh+mozilla)
Comment on attachment 604754 [details] [diff] [review]
Add support without-x

Review of attachment 604754 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +8848,5 @@
>  dnl Check for missing components
>  if test "$COMPILE_ENVIRONMENT"; then
>  if test "$MOZ_X11"; then
> +    if test "$WITHOUT_X11"
> +    then

Style nit: put that on one line.
Attachment #604754 - Flags: review?(mh+mozilla) → review+
Assignee

Comment 7

7 years ago
Style nit fixed
Attachment #604754 - Attachment is obsolete: true
Attachment #604784 - Flags: review+
Assignee

Updated

7 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2065117f4150
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.