734678 - Add support for without-x configuration

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Qt, defect)

Description

[Oleg Romashin (:romaxa)]

I think it make sense to add support for Qt qws environment configuration, which could be enabled by --without-x configure option

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Add support for without-x config option

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 604678 [details] [diff] [review]
Add support for without-x config option

Review of attachment 604678 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +4931,5 @@
>          AC_MSG_ERROR([You must specify a default toolkit (perhaps $_PLATFORM_DEFAULT_TOOLKIT).])
>      fi
>  
> +MOZ_ARG_WITHOUT_BOOL(x,
> +[  --without-x],

With a help message, please :)

@@ +4969,5 @@
>  cairo-qt)
>      MOZ_WIDGET_TOOLKIT=qt
>      MOZ_ENABLE_QT=1
> +    if test "$WITHOUT_X11"; then
> +        MOZ_TREE_FREETYPE=1

Is system freetype depending on X on these systems you're targetting? Wouldn't it make sense to leave it to the people building with --without-x to --enable-tree-freetype if they need to?

@@ +4970,5 @@
>      MOZ_WIDGET_TOOLKIT=qt
>      MOZ_ENABLE_QT=1
> +    if test "$WITHOUT_X11"; then
> +        MOZ_TREE_FREETYPE=1
> +        echo "Build qt without X11"

If you really want this message displayed, use AC_MSG_WARN. Otherwise remove it.

Comment 3

[Oleg Romashin (:romaxa)]

Attachment: Fixed comments, to push

Comment 4

[Mike Hommey [:glandium]]

You need to align the help message with the other ones. Now that I think of it, you should also AC_MSG_ERROR in case --without-x is given and MOZ_X11 is still set.

Comment 5

[Oleg Romashin (:romaxa)]

Attachment: Add support without-x

Is this good?

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 604754 [details] [diff] [review]
Add support without-x

Review of attachment 604754 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +8848,5 @@
>  dnl Check for missing components
>  if test "$COMPILE_ENVIRONMENT"; then
>  if test "$MOZ_X11"; then
> +    if test "$WITHOUT_X11"
> +    then

Style nit: put that on one line.

Comment 7

[Oleg Romashin (:romaxa)]

Attachment: Add support without-x

Style nit fixed

Comment 8

[Dão Gottwald [::dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/2065117f4150

Comment 9

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/mozilla-central/rev/2065117f4150