Closed
Bug 734678
Opened 13 years ago
Closed 13 years ago
Add support for without-x configuration
Categories
(Core Graveyard :: Widget: Qt, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla13
People
(Reporter: romaxa, Assigned: romaxa)
Details
Attachments
(1 file, 3 obsolete files)
2.28 KB,
patch
|
romaxa
:
review+
|
Details | Diff | Splinter Review |
I think it make sense to add support for Qt qws environment configuration, which could be enabled by --without-x configure option
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #604678 -
Flags: review?(mh+mozilla)
Comment 2•13 years ago
|
||
Comment on attachment 604678 [details] [diff] [review]
Add support for without-x config option
Review of attachment 604678 [details] [diff] [review]:
-----------------------------------------------------------------
::: configure.in
@@ +4931,5 @@
> AC_MSG_ERROR([You must specify a default toolkit (perhaps $_PLATFORM_DEFAULT_TOOLKIT).])
> fi
>
> +MOZ_ARG_WITHOUT_BOOL(x,
> +[ --without-x],
With a help message, please :)
@@ +4969,5 @@
> cairo-qt)
> MOZ_WIDGET_TOOLKIT=qt
> MOZ_ENABLE_QT=1
> + if test "$WITHOUT_X11"; then
> + MOZ_TREE_FREETYPE=1
Is system freetype depending on X on these systems you're targetting? Wouldn't it make sense to leave it to the people building with --without-x to --enable-tree-freetype if they need to?
@@ +4970,5 @@
> MOZ_WIDGET_TOOLKIT=qt
> MOZ_ENABLE_QT=1
> + if test "$WITHOUT_X11"; then
> + MOZ_TREE_FREETYPE=1
> + echo "Build qt without X11"
If you really want this message displayed, use AC_MSG_WARN. Otherwise remove it.
Attachment #604678 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Assignee: nobody → romaxa
Attachment #604678 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #604751 -
Flags: review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 4•13 years ago
|
||
You need to align the help message with the other ones. Now that I think of it, you should also AC_MSG_ERROR in case --without-x is given and MOZ_X11 is still set.
Keywords: checkin-needed
Assignee | ||
Comment 5•13 years ago
|
||
Is this good?
Attachment #604751 -
Attachment is obsolete: true
Attachment #604754 -
Flags: review?(mh+mozilla)
Comment 6•13 years ago
|
||
Comment on attachment 604754 [details] [diff] [review]
Add support without-x
Review of attachment 604754 [details] [diff] [review]:
-----------------------------------------------------------------
::: configure.in
@@ +8848,5 @@
> dnl Check for missing components
> if test "$COMPILE_ENVIRONMENT"; then
> if test "$MOZ_X11"; then
> + if test "$WITHOUT_X11"
> + then
Style nit: put that on one line.
Attachment #604754 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 7•13 years ago
|
||
Style nit fixed
Attachment #604754 -
Attachment is obsolete: true
Attachment #604784 -
Flags: review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 8•13 years ago
|
||
Keywords: checkin-needed
Target Milestone: --- → mozilla13
Comment 9•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•