Closed Bug 734678 Opened 13 years ago Closed 13 years ago

Add support for without-x configuration

Categories

(Core Graveyard :: Widget: Qt, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla13

People

(Reporter: romaxa, Assigned: romaxa)

Details

Attachments

(1 file, 3 obsolete files)

I think it make sense to add support for Qt qws environment configuration, which could be enabled by --without-x configure option
Attachment #604678 - Flags: review?(mh+mozilla)
Comment on attachment 604678 [details] [diff] [review] Add support for without-x config option Review of attachment 604678 [details] [diff] [review]: ----------------------------------------------------------------- ::: configure.in @@ +4931,5 @@ > AC_MSG_ERROR([You must specify a default toolkit (perhaps $_PLATFORM_DEFAULT_TOOLKIT).]) > fi > > +MOZ_ARG_WITHOUT_BOOL(x, > +[ --without-x], With a help message, please :) @@ +4969,5 @@ > cairo-qt) > MOZ_WIDGET_TOOLKIT=qt > MOZ_ENABLE_QT=1 > + if test "$WITHOUT_X11"; then > + MOZ_TREE_FREETYPE=1 Is system freetype depending on X on these systems you're targetting? Wouldn't it make sense to leave it to the people building with --without-x to --enable-tree-freetype if they need to? @@ +4970,5 @@ > MOZ_WIDGET_TOOLKIT=qt > MOZ_ENABLE_QT=1 > + if test "$WITHOUT_X11"; then > + MOZ_TREE_FREETYPE=1 > + echo "Build qt without X11" If you really want this message displayed, use AC_MSG_WARN. Otherwise remove it.
Attachment #604678 - Flags: review?(mh+mozilla) → review+
Attached patch Fixed comments, to push (obsolete) — Splinter Review
Assignee: nobody → romaxa
Attachment #604678 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #604751 - Flags: review+
Keywords: checkin-needed
You need to align the help message with the other ones. Now that I think of it, you should also AC_MSG_ERROR in case --without-x is given and MOZ_X11 is still set.
Keywords: checkin-needed
Attached patch Add support without-x (obsolete) — Splinter Review
Is this good?
Attachment #604751 - Attachment is obsolete: true
Attachment #604754 - Flags: review?(mh+mozilla)
Comment on attachment 604754 [details] [diff] [review] Add support without-x Review of attachment 604754 [details] [diff] [review]: ----------------------------------------------------------------- ::: configure.in @@ +8848,5 @@ > dnl Check for missing components > if test "$COMPILE_ENVIRONMENT"; then > if test "$MOZ_X11"; then > + if test "$WITHOUT_X11" > + then Style nit: put that on one line.
Attachment #604754 - Flags: review?(mh+mozilla) → review+
Style nit fixed
Attachment #604754 - Attachment is obsolete: true
Attachment #604784 - Flags: review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: