Intermittent mochitest-browser-chrome failure browser/components/downloads/test/browser/browser_delete_key_removes.js | The download was properly removed - Got 6, expected 5 and a few more after it

RESOLVED FIXED

Status

()

Firefox
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: RyanVM, Assigned: Paolo)

Tracking

({intermittent-failure})

Trunk
intermittent-failure
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
I guess bug 726444 comment 42 saw this coming...
https://tbpl.mozilla.org/php/getParsedLog.php?id=9981375&tree=Mozilla-Inbound

TEST-START | chrome://mochitests/content/browser/browser/components/downloads/test/browser/browser_delete_key_removes.js
TEST-PASS | chrome://mochitests/content/browser/browser/components/downloads/test/browser/browser_delete_key_removes.js | The database and the number of downloads display matches
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/downloads/test/browser/browser_delete_key_removes.js | The download was properly removed - Got 6, expected 5
Stack trace:
    JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 446
    JS frame :: chrome://mochitests/content/browser/browser/components/downloads/test/browser/browser_delete_key_removes.js :: <TOP_LEVEL> :: line 70

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/downloads/test/browser/browser_delete_key_removes.js | The download was properly removed - Got 6, expected 4
Stack trace:
    JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 446
    JS frame :: chrome://mochitests/content/browser/browser/components/downloads/test/browser/browser_delete_key_removes.js :: <TOP_LEVEL> :: line 70

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/downloads/test/browser/browser_delete_key_removes.js | The download was properly removed - Got 6, expected 3
Stack trace:
    JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 446
    JS frame :: chrome://mochitests/content/browser/browser/components/downloads/test/browser/browser_delete_key_removes.js :: <TOP_LEVEL> :: line 70

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/downloads/test/browser/browser_delete_key_removes.js | The download was properly removed - Got 6, expected 2
Stack trace:
    JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 446
    JS frame :: chrome://mochitests/content/browser/browser/components/downloads/test/browser/browser_delete_key_removes.js :: <TOP_LEVEL> :: line 70

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/downloads/test/browser/browser_delete_key_removes.js | The download was properly removed - Got 5, expected 1
Stack trace:
    JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 446
    JS frame :: chrome://mochitests/content/browser/browser/components/downloads/test/browser/browser_delete_key_removes.js :: <TOP_LEVEL> :: line 70

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/downloads/test/browser/browser_delete_key_removes.js | The download was properly removed - Got 4, expected 0
Stack trace:
    JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 446
    JS frame :: chrome://mochitests/content/browser/browser/components/downloads/test/browser/browser_delete_key_removes.js :: <TOP_LEVEL> :: line 70

INFO TEST-END | chrome://mochitests/content/browser/browser/components/downloads/test/browser/browser_delete_key_removes.js | finished in 1407ms
(Reporter)

Updated

5 years ago
Duplicate of this bug: 734702
Comment hidden (Treeherder Robot)
(Assignee)

Comment 3

5 years ago
(In reply to Ryan VanderMeulen from comment #0)
> I guess bug 726444 comment 42 saw this coming...

Actually we fixed that, it was a different case and deterministic on Mac only.

This intermittent failure is probably due to the Downloads Panel getting focus in
a delayed manner in some cases. A call to waitForFocus might fix it, I will make a
patch later today.
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 8

5 years ago
Created attachment 604771 [details] [diff] [review]
Focus the first element of the downloads list explicitly

This might fix the issue, should be verified in the field. I executed the test
locally and it still works (but, locally, it worked before as well).

I've requested review to Marco, but if someone else can review the patch sooner
and try it in the tree, it's also better.
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Attachment #604771 - Flags: review?(mak77)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Reporter)

Comment 11

5 years ago
Interesting that it only seems to happen on pgo builds.
Comment on attachment 604771 [details] [diff] [review]
Focus the first element of the downloads list explicitly

Review of attachment 604771 [details] [diff] [review]:
-----------------------------------------------------------------

may be fine, assuming there is no expected delay on setting the focus after each delete. Btw it's worth a try.
Attachment #604771 - Flags: review?(mak77) → review+
(Assignee)

Comment 13

5 years ago
This was included in the final patch, but worked only in in some cases. For now,
we have removed the test, we will add it again later.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Keywords: intermittent-failure
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.