Last Comment Bug 734706 - The Page Style menu's "No Style" menu item shouldn't have to stop the command event propagation
: The Page Style menu's "No Style" menu item shouldn't have to stop the command...
Product: Firefox
Classification: Client Software
Component: Menus (show other bugs)
: Trunk
: All All
-- normal (vote)
: Firefox 14
Assigned To: Dão Gottwald [:dao]
: Jared Wein [:jaws] (please needinfo? me)
Depends on:
  Show dependency treegraph
Reported: 2012-03-10 20:02 PST by Dão Gottwald [:dao]
Modified: 2012-03-21 02:50 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (4.34 KB, patch)
2012-03-10 20:41 PST, Dão Gottwald [:dao]
dolske: review+
Details | Diff | Splinter Review

Description User image Dão Gottwald [:dao] 2012-03-10 20:02:17 PST
see bug 733339 comment 7
Comment 1 User image Dão Gottwald [:dao] 2012-03-10 20:41:25 PST
Created attachment 604722 [details] [diff] [review]

This should do it, although I haven't tested it yet.

I kept the 'data' attribute since fillPopup would need to escape the value if put directly in oncommand.

The code handling _nostyle appears to be dead, so I removed it.
Comment 2 User image Justin Dolske [:Dolske] 2012-03-20 20:32:30 PDT
Comment on attachment 604722 [details] [diff] [review]

Nice cleanup! r+ assuming it works. :)
Comment 3 User image Dão Gottwald [:dao] 2012-03-21 02:50:39 PDT

Note You need to log in before you can comment on or make changes to this bug.