Closed
Bug 734706
Opened 12 years ago
Closed 12 years ago
The Page Style menu's "No Style" menu item shouldn't have to stop the command event propagation
Categories
(Firefox :: Menus, defect)
Firefox
Menus
Tracking
()
RESOLVED
FIXED
Firefox 14
People
(Reporter: dao, Assigned: dao)
Details
Attachments
(1 file)
|
4.34 KB,
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•12 years ago
|
||
This should do it, although I haven't tested it yet. I kept the 'data' attribute since fillPopup would need to escape the value if put directly in oncommand. The code handling _nostyle appears to be dead, so I removed it.
Assignee: nobody → dao
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•12 years ago
|
Attachment #604722 -
Flags: review?(dolske)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 604722 [details] [diff] [review] patch Nice cleanup! r+ assuming it works. :)
Attachment #604722 -
Flags: review?(dolske) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/3de967c4624c
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
You need to log in
before you can comment on or make changes to this bug.
Description
•