The Page Style menu's "No Style" menu item shouldn't have to stop the command event propagation

RESOLVED FIXED in Firefox 14

Status

()

Firefox
Menus
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
see bug 733339 comment 7
(Assignee)

Comment 1

5 years ago
Created attachment 604722 [details] [diff] [review]
patch

This should do it, although I haven't tested it yet.

I kept the 'data' attribute since fillPopup would need to escape the value if put directly in oncommand.

The code handling _nostyle appears to be dead, so I removed it.
Assignee: nobody → dao
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Attachment #604722 - Flags: review?(dolske)
Comment on attachment 604722 [details] [diff] [review]
patch

Nice cleanup! r+ assuming it works. :)
Attachment #604722 - Flags: review?(dolske) → review+
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/mozilla-central/rev/3de967c4624c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
You need to log in before you can comment on or make changes to this bug.