Closed Bug 734706 Opened 9 years ago Closed 9 years ago

The Page Style menu's "No Style" menu item shouldn't have to stop the command event propagation

Categories

(Firefox :: Menus, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 14

People

(Reporter: dao, Assigned: dao)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
This should do it, although I haven't tested it yet.

I kept the 'data' attribute since fillPopup would need to escape the value if put directly in oncommand.

The code handling _nostyle appears to be dead, so I removed it.
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #604722 - Flags: review?(dolske)
Comment on attachment 604722 [details] [diff] [review]
patch

Nice cleanup! r+ assuming it works. :)
Attachment #604722 - Flags: review?(dolske) → review+
http://hg.mozilla.org/mozilla-central/rev/3de967c4624c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
You need to log in before you can comment on or make changes to this bug.