The default bug view has changed. See this FAQ.

Port Bug 734374 to Thunderbird [Australis theme]

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Theme
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

(Blocks: 1 bug)

Trunk
Thunderbird 14.0
x86_64
Windows 7
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Assignee)

Description

5 years ago
Now that Bug 734374 has r+ I'll port this bug to Thunderbird.
(Assignee)

Updated

5 years ago
Blocks: 733854
(Assignee)

Comment 1

5 years ago
Created attachment 604767 [details] [diff] [review]
Patch

I followed the changes from Bug 734374 plus I made the searchbars background behave like Firefox on normal toolbars and the Gloda searchbox on Glass (tab-bar).
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #604767 - Flags: ui-review?(nisses.mail)
Attachment #604767 - Flags: review?(nisses.mail)
(Assignee)

Comment 2

5 years ago
Created attachment 604782 [details] [diff] [review]
Patch

I found a typo. New patch, now all should be okay. Sorry
Attachment #604767 - Attachment is obsolete: true
Attachment #604782 - Flags: ui-review?(nisses.mail)
Attachment #604782 - Flags: review?(nisses.mail)
Attachment #604767 - Flags: ui-review?(nisses.mail)
Attachment #604767 - Flags: review?(nisses.mail)

Updated

5 years ago
Blocks: 737347
Richard: Could you please provide before and after screenshots?
Either I have something wrong with my setup, these patches aint biting or I'm looking for the wrong thing :)
(Assignee)

Comment 4

5 years ago
Created attachment 607687 [details]
Comparison

Comparison. On the left the old box on the right the patch applied.

The patch is 100% like the one on Firefox and the effect is very subtle on hover. The most difference is when active.
Comment on attachment 604782 [details] [diff] [review]
Patch

ui-r based on the screenshots.
Will test it once more before I give r+
Attachment #604782 - Flags: ui-review?(nisses.mail) → ui-review+
(Assignee)

Comment 6

5 years ago
Created attachment 608776 [details] [diff] [review]
Patch v3

Patch adding the changes to #IMSearchInput. I removed the definitions in chat.css and added them to messenger.css. With this the style is only defined on one position.

I'm carrying over ui-r+ from previous patch.
Attachment #604782 - Attachment is obsolete: true
Attachment #608776 - Flags: ui-review+
Attachment #608776 - Flags: review?(nisses.mail)
Attachment #604782 - Flags: review?(nisses.mail)
Comment on attachment 608776 [details] [diff] [review]
Patch v3

Code looks good!
Attachment #608776 - Flags: review?(nisses.mail) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
This patch is bitrotted in addressbook-aero.css. Please rebase.
Keywords: checkin-needed
(Assignee)

Comment 9

5 years ago
Created attachment 609740 [details] [diff] [review]
Patch for check-in

Unbitrotted patch.

Carrying over review flags from previous patch.
Attachment #608776 - Attachment is obsolete: true
Attachment #609740 - Flags: ui-review+
Attachment #609740 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/110e8543f72f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
You need to log in before you can comment on or make changes to this bug.