Closed Bug 734822 Opened 12 years ago Closed 6 years ago

Fx13 nightly stop compatibility check slow

Categories

(Toolkit :: Add-ons Manager, defect)

13 Branch
x86_64
Windows 7
defect
Not set
minor

Tracking

()

RESOLVED INACTIVE

People

(Reporter: dindog, Unassigned)

References

Details

(Keywords: regression)

I switch same profile from nightly to aurora and beta now and then, and every times version changed, Firefox will check compatibility of installed addon, and I just cancel it every times. 

Fx13 nightly won't stop right after I click "cancel", but a few seconds after that.
Regression window(m-c),
Cannor reproduce:
http://hg.mozilla.org/mozilla-central/rev/81f6b9cbb2a9
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0a1) Gecko/20120214 Firefox/13.0a1 ID:20120215021649
Can reproduce:
http://hg.mozilla.org/mozilla-central/rev/46e22ce549b0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0a1) Gecko/20120215 Firefox/13.0a1 ID:20120215083849
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=81f6b9cbb2a9&tochange=46e22ce549b0


Regression window(m-i),
Cannor reproduce:
http://hg.mozilla.org/integration/mozilla-inbound/rev/f9599a2d85a5
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0a1) Gecko/20120214 Firefox/13.0a1 ID:20120214172552
Can reproduce:
http://hg.mozilla.org/integration/mozilla-inbound/rev/4066c46534b9
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0a1) Gecko/20120214 Firefox/13.0a1 ID:20120214180849
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f9599a2d85a5&tochange=4066c46534b9
Suspected:
78a838663c7d	Blair McBride — Bug 718630 - Add-ons with compatibility override are displayed as enabled and incompatible if skipping compatibility check after upgrade. r=dtownsend
Blocks: 718630
Component: Extension Compatibility → Add-ons Manager
Product: Firefox → Toolkit
QA Contact: extension.compatibility → add-ons.manager
Yea, that was intentional, as part of the fix for bug 718630. It's waiting now because it has to wait for a network request to finish - not waiting breaks things (bug 718630), and we can't cancel it yet. 

I have a rough plan that could allow canceling that request, but it requires partially rewriting a component (AddonRepository.jsm) :( So I don't think there's anything that can be done in the short-term.
Severity: normal → minor
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.