Closed Bug 734856 Opened 13 years ago Closed 12 years ago

atlbase.h needed by webrtc in windows

Categories

(Core :: WebRTC, defect)

Product:
Core
Component:
WebRTC
Platform:
Other
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: jesup, Unassigned)

References

Details

(Whiteboard: [WebRTC], [blocking-webrtc-])

win32devicemanager.cc uses atlbase.h, which is problematic for people using the free versions of MS VS. Installing the 2003 SDK caused some problems with VS2010 (to be attached).
Blocks: 699646
This is really unfortunate. The ideal solution here would be to have this code rewritten to not use ATL. The crappy solution is to add the configure test back, and force people using the free toolchains to --disable-webrtc to get a working build. Making people disable a huge chunk of cool new web functionality just because they're using a free toolchain is really crappy, though.
QA Contact: jsmith
Did this get fixed upstream, or is it still an issue?
Whiteboard: [WebRTC], [blocking-webrtc-]
Gone in upstream/3.20 (and I think 3.12 as well)
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.