734903 - Undefined reference to XRE_GetProcessType in nsMediaCacheRemover.cpp on mingw

Status: RESOLVED FIXED

Description

[Jacek Caban]

Created attachment 604983 [details] [diff] [review]
fix v1.0

It's because xpcom/io is missing |LIBXUL_LIBRARY  = 1|. Without it, XRE_GetProcessType (used after landing bug 612246) is declared as dllimport, while we shouldn't be importing it (it's compiled into xul.dll together with nsMediaCacheRemover.cpp).

The attached patch passes on try:
https://tbpl.mozilla.org/?tree=Try&rev=5b66e667452f

Comment 1

[Chris Pearce (:cpearce)]

Comment on attachment 604983 [details] [diff] [review]
fix v1.0

Review of attachment 604983 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me, but I'm not an XPCOM peer, so we'd better ask one of them for review instead.

Comment 2

[Jacek Caban]

Thanks for reviews.

https://hg.mozilla.org/integration/mozilla-inbound/rev/cec986f756d4

Comment 3

[Marco Bonardo [::mak]]

https://hg.mozilla.org/mozilla-central/rev/cec986f756d4