Undefined reference to XRE_GetProcessType in nsMediaCacheRemover.cpp on mingw
RESOLVED
FIXED
in mozilla14
Status
()
People
(Reporter: jacek, Assigned: jacek)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment)
|
628 bytes,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
Created attachment 604983 [details] [diff] [review] fix v1.0 It's because xpcom/io is missing |LIBXUL_LIBRARY = 1|. Without it, XRE_GetProcessType (used after landing bug 612246) is declared as dllimport, while we shouldn't be importing it (it's compiled into xul.dll together with nsMediaCacheRemover.cpp). The attached patch passes on try: https://tbpl.mozilla.org/?tree=Try&rev=5b66e667452f
Attachment #604983 -
Flags: review?(cpearce)
|
||
Comment 1•7 years ago
|
||
Comment on attachment 604983 [details] [diff] [review] fix v1.0 Review of attachment 604983 [details] [diff] [review]: ----------------------------------------------------------------- Looks fine to me, but I'm not an XPCOM peer, so we'd better ask one of them for review instead.
Attachment #604983 -
Flags: review?(cpearce) → review?(benjamin)
|
||
Updated•7 years ago
|
Attachment #604983 -
Flags: review?(benjamin) → review+
|
(Assignee) | |
Comment 2•7 years ago
|
||
Thanks for reviews. https://hg.mozilla.org/integration/mozilla-inbound/rev/cec986f756d4
Whiteboard: [inbound]
|
||
Comment 3•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cec986f756d4
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla14
You need to log in
before you can comment on or make changes to this bug.
Description
•