Closed Bug 734915 Opened 8 years ago Closed 8 years ago

Replace the feed subscribe folderpicker with new methods

Categories

(MailNews Core :: Feed Reader, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 14.0

People

(Reporter: alta88, Assigned: alta88)

Details

Attachments

(1 file, 4 obsolete files)

No description provided.
Attached patch patch. (obsolete) — Splinter Review
1. replace old rdf rules to newer binding based picker.
2. show path not just leaf folder name.
3. when folder selected, allow click/enter toggle to display folder pretty path and absolute file path.
4. ensure keyboard works for all actions.
Assignee: nobody → alta88
Attachment #604993 - Flags: review?(dbienvenu)
Attached patch patch. (obsolete) — Splinter Review
tweak..
Attachment #604993 - Attachment is obsolete: true
Attachment #604999 - Flags: review?(dbienvenu)
Attachment #604993 - Flags: review?(dbienvenu)
Attached patch patch. (obsolete) — Splinter Review
5. 'loading' message for feedback on long tree builds.

final tweak...
Attachment #604999 - Attachment is obsolete: true
Attachment #605242 - Flags: review?(dbienvenu)
Attachment #604999 - Flags: review?(dbienvenu)
Comment on attachment 605242 [details] [diff] [review]
patch.

Just a quick drive-by.

>+  setFolderPicker: function(aFolder)
>   {
>     let selectFolder = document.getElementById("selectFolder");
>+    let selectFolderPopup = document.getElementById("selectFolderPopup");
>+    let selectFolderValue = document.getElementById("selectFolderValue");
These 3 definitions could probably be moved after the early return as they're not needed until after then.
>     let editFeed = document.getElementById("editFeed");
> 
>+    let folderPrettyPath = FeedUtils.getFolderPrettyPath(aFolder);
>+    if (!folderPrettyPath)
>       return editFeed.disabled = true;
> 
>+    selectFolderPopup.selectFolder(aFolder);
As this is only used the once you could probably inline it and remove selectFolderPopup definition.


>+  getFolderPrettyPath: function(aFolder) {
>+    let folderPrettyPath = null;
>+    let msgFolder = GetMsgFolderFromUri(aFolder.URI, true);
>+    if (!msgFolder)
>+      // Not a real folder uri.
>+      return folderPrettyPath;
Just return null here, makes it more obvious and avoids having to create the variable folderPrettyPath.

>+    // Leaf folder last.
>+    pathParts.push(aFolder.name);
>+    folderPrettyPath = decodeURI(pathParts.join(" / "));
Just return the decodeURI here rather setting it to the variable and returning that.
>+
>+    return folderPrettyPath;
Attached patch patch. (obsolete) — Splinter Review
sure.
Attachment #605242 - Attachment is obsolete: true
Attachment #605945 - Flags: review?(dbienvenu)
Attachment #605242 - Flags: review?(dbienvenu)
Attached patch patch.Splinter Review
final final tweak, for real.  (make keyboard folderpicking/update work for non visible folders.)
Attachment #605945 - Attachment is obsolete: true
Attachment #606396 - Flags: review?(dbienvenu)
Attachment #605945 - Flags: review?(dbienvenu)
Attachment #606396 - Flags: review?(dbienvenu) → review+
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/70af4549f05b
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite?
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.