Closed Bug 734975 Opened 8 years ago Closed 8 years ago

Remove the XULRunner installer on Mac and switch the package to a .tar.bz2

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla14

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

(Keywords: dev-doc-needed)

Attachments

(2 files, 2 obsolete files)

Currently we package a XULRunner installer on mac which will install XULRunner to /Library/Frameworks/XUL.framework. This wasn't a good idea to begin with and we removed support for even searching in system locations a while back. We want application authors to package XULRunner in their individual application bundles. To that end, I have removed the installer generation code and am just going "back" to packaging a .tar.bz2 file.
Attached patch Remove the installer, rev. 1 (obsolete) — Splinter Review
Attachment #605046 - Flags: review?(dtownsend+bugmail)
Comment on attachment 605046 [details] [diff] [review]
Remove the installer, rev. 1

Review of attachment 605046 [details] [diff] [review]:
-----------------------------------------------------------------

This doesn't include the removals for xulrunner/installer/mac. Is that a mistake or intentional?

The readme looks good to me, I think as long as it links to the website then that should give everyone all the info they might want. Do we want to mention the license or is a LICENSE file already included somewhere?
There is a separate LICENSE file. Not including the xulrunner/installer/mac removal in the patch was accidental. `hg rm` and `rm` aren't identical ;-)
Attachment #605046 - Attachment is obsolete: true
Attachment #605757 - Flags: review?(dtownsend+bugmail)
Attachment #605046 - Flags: review?(dtownsend+bugmail)
Attachment #605757 - Flags: review?(dtownsend+bugmail) → review+
https://hg.mozilla.org/mozilla-central/rev/6fd5e0d9d94b
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
This broke the universal build due to flight.mk referencing xulrunner/installer/mac: I'll work on fixing that tomorrow.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: XULRunner mac nightlies currently busted, working on a fix
Attached patch bustage fix WIP (obsolete) — Splinter Review
This at least makes the build and package steps complete in universal builds. I haven't done any testing in non-UB or comparisons to what was generated before and after yet though.
Attached patch bustage fixSplinter Review
I've run builds locally in both non-universal and universal and all succeed and package both XULRunner and the SDK ok. I didn't go so far as comparing the exact files included because of one complication, it turns out that we now omnijar XULRunner where we didn't when doing a pkg. A brief check shows all relevant files are present and I can run an application with the generated framework.

There were a bunch of problems with packaging here, mostly stemming from the fact that all of the support for packaging a bundle is ifdeffed behind a check for the package format being DMG. I suspect it doesn't need to be ifdeffed behind anything but to minimise the potential for breakage elsewhere I hid it behind toolkit=cocoa here.

I also made a slight change to where we tar file from so the tarball contains the XUL.framework directory directly (rather than xulrunner/XUL.framework).
Attachment #611093 - Attachment is obsolete: true
Attachment #612399 - Flags: review?(benjamin)
Comment on attachment 612399 [details] [diff] [review]
bustage fix

Yeah, I got halfway through writing the same patch and got stuck! thanks for finishing this.
Attachment #612399 - Flags: review?(benjamin) → review+
Landed on inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/d36aeec1abe1
Whiteboard: XULRunner mac nightlies currently busted, working on a fix
https://hg.mozilla.org/mozilla-central/rev/d36aeec1abe1
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Depends on: 743560
This is a pretty significant change for XULRunner app developers.  The XULRunner docs could use some tender loving care, anyway...
Keywords: dev-doc-needed
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.