Closed
Bug 734992
Opened 13 years ago
Closed 13 years ago
Remove duplicate html tag id's in Balrog's Permissions page
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: edransch, Assigned: bhearsum)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.29 KB,
patch
|
rail
:
review+
edransch
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
The Permissions page in Balrog's admin interface currently has some duplicate id's.
html standards require id's to be unique.
|
Reporter | |
Updated•13 years ago
|
Assignee: edransch → bhearsum
|
Assignee | |
Comment 1•13 years ago
|
||
I ran permissions.html, user_permissions.html, and releases.html through the W3 validator. Other than this one ID, everything else passed.
I filed bug 739303 about automatically testing Balrog HTML.
Attachment #609378 -
Flags: review?(rail)
|
|
||
Updated•13 years ago
|
Attachment #609378 -
Flags: review?(rail) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
Erick pointed out that I need to update the onclick handlers, too.
Attachment #609378 -
Attachment is obsolete: true
Attachment #609389 -
Flags: review?(rail)
Attachment #609389 -
Flags: review?(edransch)
|
|
||
Updated•13 years ago
|
Attachment #609389 -
Flags: review?(rail) → review+
|
|
Reporter | |
Updated•13 years ago
|
Attachment #609389 -
Flags: review?(edransch) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 609389 [details] [diff] [review]
update onclick code, too
Landed this, Jenkins run is here: https://jenkins.mozilla.org/job/Balrog/65/
Attachment #609389 -
Flags: checked-in+
|
|
Assignee | |
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
|
|
||
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•