Closed Bug 735083 Opened 8 years ago Closed 8 years ago

Batch inserts into Fennec history provider

Categories

(Firefox for Android :: Android Sync, defect, P1)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
mozilla14
Tracking Status
blocking-fennec1.0 --- beta+

People

(Reporter: rnewman, Assigned: nalexander)

References

Details

(Keywords: perf)

Splitting Bug 713542 in two, because history is *much* easier.
Blocks: 722379
Blocks: 737439
blocking-fennec1.0: --- → ?
Priority: P2 → P1
blocking-fennec1.0: ? → beta+
Assignee: nobody → nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/72ae9117ba88
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/72ae9117ba88
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
qa-, unless you STR's can be provided to verify this.
Whiteboard: [qa-]
(In reply to Tracy Walker [:tracy] from comment #5)
> qa-, unless you STR's can be provided to verify this.

I don't feel this change is important to verify, but:

* adb shell setprop log.tag.BrowserDataAccessor VERBOSE
* adb shell setprop log.tag.ABHistoryRepoSess VERBOSE
* restart Fennec (to catch new logging settings)
* sync a profile with lots of incoming history items (preferably more than 50)
* verify log messages like this appear:

D ABHistoryRepoSess(????)               Flushing 50 records to database.
D BrowserDataAccessor(????)             Inserted 50 records, as expected.

* verify no log messages like the following appear (these are not fatal, but could indicate a problem):

D BrowserDataAccessor(????)             Inserted 49 records but expected 50 records; continuing to update visits.
Whiteboard: [qa-]
Status: RESOLVED → VERIFIED
Product: Mozilla Services → Android Background Services
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.