735083 - Batch inserts into Fennec history provider

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Android Sync, defect, P1)

Description

[Richard Newman [:rnewman]]

Splitting Bug 713542 in two, because history is *much* easier.

Comment 1

[Nick Alexander :nalexander [he/him]]

https://github.com/mozilla-services/android-sync/pull/147

Comment 2

[Nick Alexander :nalexander [he/him]]

In develop:

https://github.com/mozilla-services/android-sync/commit/df260c3cc6caf63d7273660f2d4bf55f66adfdad

Comment 3

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/72ae9117ba88

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/72ae9117ba88

Comment 5

[Tracy Walker [:tracy]]

qa-, unless you STR's can be provided to verify this.

Comment 6

[Nick Alexander :nalexander [he/him]]

(In reply to Tracy Walker [:tracy] from comment #5)
> qa-, unless you STR's can be provided to verify this.

I don't feel this change is important to verify, but:

* adb shell setprop log.tag.BrowserDataAccessor VERBOSE
* adb shell setprop log.tag.ABHistoryRepoSess VERBOSE
* restart Fennec (to catch new logging settings)
* sync a profile with lots of incoming history items (preferably more than 50)
* verify log messages like this appear:

D ABHistoryRepoSess(????)               Flushing 50 records to database.
D BrowserDataAccessor(????)             Inserted 50 records, as expected.

* verify no log messages like the following appear (these are not fatal, but could indicate a problem):

D BrowserDataAccessor(????)             Inserted 49 records but expected 50 records; continuing to update visits.