735112 - java.util.ConcurrentModificationException at java.util.HashMap$HashIterator.nextEntry(HashMap.java) at org.mozilla.gecko.GeckoApp.hidePlugins(GeckoApp.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

This bug was filed from the Socorro interface and is 
report bp-965f1828-cba4-49bc-bae3-473102120310 .
============================================================= 
java.util.ConcurrentModificationException
	at java.util.HashMap$HashIterator.nextEntry(HashMap.java:792)
	at java.util.HashMap$ValueIterator.next(HashMap.java:824)
	at org.mozilla.gecko.GeckoApp.hidePlugins(GeckoApp.java:1549)
	at org.mozilla.gecko.GeckoApp$4.run(GeckoApp.java:755)
	at android.os.Handler.handleCallback(Handler.java:605)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at org.mozilla.gecko.GeckoApp$32.run(GeckoApp.java:1777)
	at android.os.Handler.handleCallback(Handler.java:605)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4424)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:787)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:554)
	at dalvik.system.NativeStart.main(Native Method)

https://crash-stats.mozilla.com/report/list?version=FennecAndroid%3A12.0a2&query_search=signature&query_type=contains&reason_type=contains&date=2012-03-12&range_value=28&range_unit=days&hang_type=any&process_type=any&signature=java.util.ConcurrentModificationException%3A%20at%20java.util.HashMap%24HashIterator.nextEntry%28HashMap.java%29

Earliest report : 20120223042013

Comment 1

[Martijn Wargers (dead)]

I was getting this crash with the testcase from bug 727512, open the tab list popup, closing the parent tab that is endlessly opening all the windows.

Comment 2

[Martijn Wargers (dead)]

Attachment: testcase

The crash in comment 1 might be a little bit different.

This testcase gives the same crash as what is mentioned in comment 0:
https://crash-stats.mozilla.com/report/index/bp-62833bfa-8d32-460b-932f-ea8382120525
Reproduced this on the Galaxy Nexus.

Steps to reproduce:
- Make sure you have Plugins enabled in the settings
- Visit testcase, tap on the button
- When popups are blocked after the second popup, let it allow popups for this site.

After a few times opening/closing windows, it should crash Fennec.

Comment 3

[Martijn Wargers (dead)]

This was relatively easy to find now that bug 731288 is fixed, btw.

Asking for blocking, since this crash bug now has a testcase.

Comment 4

[Martijn Wargers (dead)]

The opened window code consists of this:
<embed type="application/x-shockwave-flash">
<embed type="application/x-shockwave-flash">
<script>
setTimeout(function() {document.write('test');}, 5000);
</script>

Comment 5

[Martijn Wargers (dead)]

Why does this bug have gotten 'qawanted' keyword. What does QA need to do here?
I attached a testcase that reproduces the crash. Or are you not able to reproduce the crash?

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

qawanted is to retest, assertion being that this may be fixed already

Comment 7

[Martijn Wargers (dead)]

Ok, current trunk build doesn't seem to crash anymore with the testcase on the Galaxy Nexus and the Galaxy SII. Marking WFM.

Comment 8

[Scoobidiver (away)]

There's one crash in 14.0b6 with the stack in comment 0: bp-bd9703c1-37f2-4043-90fc-0b7702120608.

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Add some thread synchronization for plugin layers

Comment 10

[Scoobidiver (away)]

It still happens. Can someone land the patch?

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Green on Try.
https://tbpl.mozilla.org/?tree=Try&rev=2ec9ffb953d7

https://hg.mozilla.org/integration/mozilla-inbound/rev/36f21854b627

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/36f21854b627