The default bug view has changed. See this FAQ.

Fix "does't" spelling

RESOLVED FIXED in Thunderbird 15.0

Status

MailNews Core
Backend
P4
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sgautherie, Assigned: Infinity)

Tracking

Trunk
Thunderbird 15.0
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=sgautherie] [meta], URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Use "doesn't".

"Found 10 matching lines in 9 files"
Flags: in-testsuite-

Comment 1

5 years ago
Hello. I would like to work on this bug.
(Reporter)

Comment 2

5 years ago
Just do.
(Reporter)

Comment 3

5 years ago
I'm not sure whether libtheora is "upstream" or not.
nss is a separate (managed) project.
mail and mailnews can be done together or separately (bugs or patches).
Blocks: 735127
No longer blocks: 735127
Assignee: nobody → junky.argonaut
Status: NEW → ASSIGNED
(Assignee)

Comment 4

5 years ago
Created attachment 611871 [details] [diff] [review]
Patch with missing file

I have a problem with the content in source/mozilla/media/libtheora/lib/x86/x86int.h
I have http://pastebin.mozilla.org/1552263 as opposed to http://mxr.mozilla.org/comm-central/source/mozilla/media/libtheora/lib/x86/x86int.h
Could you tell me what could have gone wrong?
I updated my source as well. I cloned it from http://hg.mozilla.org/releases/comm-1.9.2/
Attachment #611871 - Flags: feedback?(sgautherie.bz)
A few things:

 (1) comm-1.9.2 (which you cloned from) is old (whatever the Thunderbird equivalent of Firefox 3.6)  It's only taking security fixes, I believe -- you don't want to do any work off of that branch.

 (2) comm-central (which your MXR link points to) is "downstream" from the main Mozilla repository -- it's Thunderbird/Seamonkey-specific.  So -- unless you're touching mail/seamonkey-specific code, you don't want to be basing a patch against comm-central.  libtheora isn't in the mail/seamonkey-specific category, so you don't want to be using comm-central for that.

 (3) libtheora itself might be snapshotted from an outside-of-mozilla source -- I'm not sure (?)  I think that's what serge was saying in comment 3.  In particular, see this file:
  http://mxr.mozilla.org/mozilla-central/source/media/libtheora/README_MOZILLA
It says we snapshot libtheora from upstream.  I'm not sure on how to get patches into libtheora, but I suspect you don't want to do it in Mozilla code, or else your change will just get stomped on the next time we update.

So: basically, I'd suggest asking in irc.mozilla.org #media and/or digging around http://www.xiph.org/ to find out how to contribute patches upstream to libtheora. :)  That, or just ignore libtheora for the purpose of this bug.
(Assignee)

Comment 6

5 years ago
Let me see what  can do about the libtheora. :bwinton was just telling me about my mistake. He thinks I should download comm-central. So I am going to do that. Thanks for the suggestion on libtheora. Feedback is what I most want :) Hopefully :sgautherie or someone can help us out with it ! :)
(Reporter)

Comment 7

5 years ago
Comment on attachment 611871 [details] [diff] [review]
Patch with missing file

Per previous comments,
ensure this applies cleanly to comm-central;
and ignore libtheora wrt this bug.
Attachment #611871 - Flags: review?(mbanner)
Attachment #611871 - Flags: feedback?(sgautherie.bz)
Attachment #611871 - Flags: feedback+
(Reporter)

Comment 8

5 years ago
(In reply to Serge Gautherie (:sgautherie) from comment #3)
> nss is a separate (managed) project.

nss seems to have been fixed in the meantime.
Component: General → Backend
Product: Core → MailNews Core
QA Contact: general → backend
Target Milestone: --- → Thunderbird 14.0
(Reporter)

Comment 9

5 years ago
See
https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
(Assignee)

Comment 10

5 years ago
So you just want me to make the corrections in the files indicated by the path specified by the URL and do the diff ?
I am downloading the appropriate repo.
I will do the patch once I am done.
(Assignee)

Comment 11

5 years ago
I have downloaded the right repo and generated the patch. What tests do I have to perform to check if the patch I have generated fits in?
(Assignee)

Comment 12

5 years ago
Created attachment 614470 [details] [diff] [review]
My new patch(not yet tested)

I would like to know if I have to perform any tests to check the validity of this patch.
Attachment #611871 - Attachment is obsolete: true
Attachment #614470 - Flags: feedback?(sgautherie.bz)
Attachment #611871 - Flags: review?(mbanner)
(In reply to Arjun from comment #12)
> I would like to know if I have to perform any tests to check the validity of
> this patch.

No testing necessary for comment-only patches, which this basically is. (aside from the log() tweak, which is just tweaking a logged string and is hence non-scary/not needed to be tested)
(Reporter)

Updated

5 years ago
Attachment #614470 - Flags: feedback?(sgautherie.bz) → review?(mbanner)
Comment on attachment 614470 [details] [diff] [review]
My new patch(not yet tested)

Review of attachment 614470 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay in getting to this. r=Standard8
Attachment #614470 - Flags: review?(mbanner) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Thanks for the patch, Arjun! The tree is closed at the moment, but I will land your patch as soon as it reopens. One request - please make sure that your future patches have the patch metadata in them (your name, patch description, etc) as mentioned by the link from comment 9. It makes life easier for those checking in patches on your behalf.
(Assignee)

Comment 16

5 years ago
Ryan VanderMeulen: Sorry about that. Will include the metadata in my future patches.
Looking forward to when the tree will reopen so that my patch gets published. Thanks a lot for the check in on my behalf.
http://hg.mozilla.org/comm-central/rev/471d5b7228dc
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: Thunderbird 14.0 → Thunderbird 15.0
You need to log in before you can comment on or make changes to this bug.