735180 - Maple: support.mozilla.org - Page Menu pops-up when dragging down the page

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Catalin Suciu [:csuciu]]

Maple nightly 13.0a1 2012-03-12 (20120312155232)
Samsung Galaxy SII (Android 2.3.4)

Steps:
1. Load support.mozilla.org
2. Drag the page down. Do not tap on the page Menu button.

Expected:
The page Menu should not expand without tapping on the Menu button  

Actual:
The page Menu will expand outside the page, in the upper side, while dragging down the page.

Note
Unreproducible on Nexus S (Android 2.3.6).

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

This regressed when I moved the display port calculations from JS to Java, because in Java we can have overscroll and so "negative" display port margins actually make sense.

Comment 2

[Chris Lord [:cwiiis]]

Comment on attachment 605400 [details] [diff] [review]
Patch

Review of attachment 605400 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, some details clarified over IRC but I don't think this requires elaboration.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/projects/maple/rev/20a6f6aee48c

Comment 4

[Kartikaya Gupta (email:[e-mail])]

For future reference, the STR I used to reproduce the problem were:

1. load support.mozilla.org
2. pinch zoom in so that you can see the background around the page
3. lift one finger while leaving the second one down
4. pull the page down with the remaining finger, then pause and wait for a redraw

expected results: page draws properly
observed results: at this point the menu will get drawn into the overscroll area above the page

Comment 5

[Catalin Suciu [:csuciu]]

Verified fixed on:
Nightly 14.0a1 (2012-04-12) 20120412030726
Samsung Galaxy SII (Android 2.3.4)