gfxDWriteFontList.cpp fails to compile on mingw

RESOLVED FIXED in mozilla14

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla14
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 605343 [details] [diff] [review]
fix v1.0

It's mostly because mingw can't provide macros like __in as they would conflict with c++ standard includes. It's no-op anyways so it's safe to remove it. Also Interlocked* functions take long*, not usigned long*, as argument, so I've changed mRefCount's type. While I was at this I've fixed warnings (signed-unsigned compare, NULL instead of 0 for integer args and unused variables).
Attachment #605343 - Flags: review?(jdaggett)

Comment 1

5 years ago
Comment on attachment 605343 [details] [diff] [review]
fix v1.0

Sorry, I'm not really sure I understand how to review your changes.  Switching this review to bas, who may understand these issues better than I do.
Attachment #605343 - Flags: review?(jdaggett) → review?(bas.schouten)
(Assignee)

Comment 2

5 years ago
Bas, ping
Comment on attachment 605343 [details] [diff] [review]
fix v1.0

Review of attachment 605343 [details] [diff] [review]:
-----------------------------------------------------------------

Nothing objectionable here if it makes both mingw and MSVC happy.
Attachment #605343 - Flags: review?(bas.schouten) → review+
(Assignee)

Comment 4

5 years ago
Thanks for the review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/c52251654441
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/c52251654441
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.