The default bug view has changed. See this FAQ.

Status icons styled incorrectly

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Theme
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: andreasn, Assigned: andreasn)

Tracking

Trunk
Thunderbird 14.0
All
Windows 7
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird13 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
There are two places that we still display wrongly styled status icons (from the shared resource rather than from the individual platform theme)

1. Tools > Chat status > Unavailable
2. The icons in the Tools > Chat status > Show accounts dialog.
(Assignee)

Comment 1

5 years ago
Created attachment 605423 [details] [diff] [review]
Patch to fix the issue

As a bonus, I broke out some ifdef's in imAccounts.css
Only tested on Windows so far.
(Assignee)

Updated

5 years ago
Blocks: 714733
(Assignee)

Comment 2

5 years ago
Created attachment 605726 [details] [diff] [review]
works in osx too

Seems I forgot the Pinstripe part yesterday. Works on Mac too now.
Attachment #605423 - Attachment is obsolete: true
(Assignee)

Comment 3

5 years ago
Created attachment 606037 [details] [diff] [review]
and works correctly on Linux too

Had to do some extra tricks in gnomestripe to show the icons in the two status menus.
Attachment #605726 - Attachment is obsolete: true
Attachment #606037 - Flags: ui-review?(bwinton)
Attachment #606037 - Flags: review?(mconley)
Comment on attachment 606037 [details] [diff] [review]
and works correctly on Linux too

Review of attachment 606037 [details] [diff] [review]:
-----------------------------------------------------------------

Andreas:

This makes sense to me - good work!  Just one question about the "displayNameAndstatusMessageStack" id.  Assuming my assumption is correct, r=me.

Thanks,

-Mike

::: mail/components/im/themes/imAccounts.css
@@ +342,3 @@
>  #statusTypeIcon[status="idle"] {
>    list-style-image: url('chrome://chat/skin/idle-16.png');
>  }

Hooray for axeing ifdefs! :)

::: mail/themes/pinstripe/mail/chat.css
@@ +166,5 @@
> +#displayNameAndstatusMessageStack #statusMessage[editing] {
> +  margin: 29px 2px 0 -4px;
> +}
> +
> +#displayNameAndstatusMessageStack #displayName[editing] {

I assume the ID for this element is indeed @displayNameAndstatusMessageStack, with the lowercased "s" in status, and not a copy-paste error...correct?
Attachment #606037 - Flags: review?(mconley) → review+
(Assignee)

Comment 5

5 years ago
(In reply to Mike Conley (:mconley) from comment #4)

> > +#displayNameAndstatusMessageStack #displayName[editing] {
> 
> I assume the ID for this element is indeed
> @displayNameAndstatusMessageStack, with the lowercased "s" in status, and
> not a copy-paste error...correct?

Yes.
http://mxr.mozilla.org/comm-central/source/mail/components/im/content/imAccounts.xul#149
(In reply to Andreas Nilsson (:andreasn) from comment #5)
> (In reply to Mike Conley (:mconley) from comment #4)
> 
> > > +#displayNameAndstatusMessageStack #displayName[editing] {
> > 
> > I assume the ID for this element is indeed
> > @displayNameAndstatusMessageStack, with the lowercased "s" in status, and
> > not a copy-paste error...correct?
> 
> Yes.
> http://mxr.mozilla.org/comm-central/source/mail/components/im/content/
> imAccounts.xul#149

Cool, looks good then. :)
Comment on attachment 606037 [details] [diff] [review]
and works correctly on Linux too

I'm going to say ui-r=me, based on the Mac, and hoping that the other platforms also work.  ;)

Thanks,
Blake.
Attachment #606037 - Flags: ui-review?(bwinton) → ui-review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/3aecafffd8e9

Also, to make life easier for those checking in patches for you, please follow the directions below for any future patches you submit. Thanks!
https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Assignee: nobody → nisses.mail
Comment on attachment 606037 [details] [diff] [review]
and works correctly on Linux too

[Approval Request Comment]
User impact if declined: inconsistency between the status icons displayed in different places of the UI.
Attachment #606037 - Flags: approval-comm-aurora?

Updated

5 years ago
Attachment #606037 - Flags: approval-comm-aurora? → approval-comm-aurora+
http://hg.mozilla.org/releases/comm-aurora/rev/71030ae61bce
status-thunderbird13: --- → fixed
You need to log in before you can comment on or make changes to this bug.