73526 - Text misplaced in table

Status: RESOLVED WORKSFORME

(Core :: Layout: Tables, defect)

Description

[Mike Pinkerton (not reading bugmail)]

load the attached page, the text:

"Spanish-language video reports address issues important to the area's Latino
residents." 

is totally out of place.

Comment 1

[Mike Pinkerton (not reading bugmail)]

Attachment: html that shows table bug

Comment 2

[Mike Pinkerton (not reading bugmail)]

i can give you a screenshot if you'd like

Comment 3

[Bernd]

I think this is a regression because it does not appear with 2001031204 Win98
but with a current CVS build under Win98. One of the reflow optimizations seems
to be overagressive.


and the URL  asserts like hell:

first come NS_PRECONDITION(PR_FALSE, "not a container");

trace:

nsDebug::Assertion(const char * 0x02530530, const char * 0x02530524, const char
* 0x025304e4, int 350) line 286 + 13 bytes
nsDebug::PreCondition(const char * 0x02530530, const char * 0x02530524, const
char * 0x025304e4, int 350) line 430 + 21 bytes
nsFrame::AppendFrames(nsFrame * const 0x0283e35c, nsIPresContext * 0x036ffee0,
nsIPresShell & {...}, nsIAtom * 0x00000000, nsIFrame * 0x0283e398) line 350 + 35
bytes
FrameManager::AppendFrames(FrameManager * const 0x036a2ac0, nsIPresContext *
0x036ffee0, nsIPresShell & {...}, nsIFrame * 0x0283e35c, nsIAtom * 0x00000000,
nsIFrame * 0x0283e398) line 779
nsCSSFrameConstructor::AppendFrames(nsIPresContext * 0x036ffee0, nsIPresShell *
0x036a0d50, nsIFrameManager * 0x036a2ac0, nsIContent * 0x03731f70, nsIFrame *
0x0283e35c, nsIFrame * 0x0283e398) line 7582 + 30 bytes
nsCSSFrameConstructor::ContentAppended(nsCSSFrameConstructor * const 0x036a7b50,
nsIPresContext * 0x036ffee0, nsIContent * 0x03731f70, int 0) line 8133
StyleSetImpl::ContentAppended(StyleSetImpl * const 0x036a7c80, nsIPresContext *
0x036ffee0, nsIContent * 0x03731f70, int 0) line 1215
PresShell::ContentAppended(PresShell * const 0x036a0d58, nsIDocument *
0x036e9a80, nsIContent * 0x03731f70, int 0) line 4406 + 46 bytes
nsDocument::ContentAppended(nsDocument * const 0x036e9a80, nsIContent *
0x03731f70, int 0) line 1596
nsHTMLDocument::ContentAppended(nsHTMLDocument * const 0x036e9a80, nsIContent *
0x03731f70, int 0) line 1256
HTMLContentSink::NotifyAppend(nsIContent * 0x03731f70, int 0) line 4544
SinkContext::FlushTags(int 1) line 2047
.......

and then comes

NS_ASSERTION(HadInitialReflow(), "intial reflow not called");

nsDebug::Assertion(const char * 0x025431bc, const char * 0x025431a8, const char
* 0x02543164, int 1809) line 286 + 13 bytes
nsTableFrame::Reflow(nsTableFrame * const 0x0293eea8, nsIPresContext *
0x036ffee0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...},
unsigned int & 0) line 1809 + 38 bytes
nsContainerFrame::ReflowChild(nsIFrame * 0x0293eea8, nsIPresContext *
0x036ffee0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, int 0,
int 0, unsigned int 3, unsigned int & 0) line 692 + 31 bytes
nsTableOuterFrame::OuterReflowChild(nsTableOuterFrame * const 0x0293ee5c,
nsIPresContext * 0x036ffee0, nsIFrame * 0x0293eea8, const nsHTMLReflowState &
{...}, nsHTMLReflowMetrics & {...}, int * 0x00000000, nsSize & {...}, nsMargin &
{...}, nsMargin & {...}, nsMargin & {...}, nsReflowReason
eReflowReason_Incremental, unsigned int & 0) line 894 + 47 bytes
nsTableOuterFrame::IR_InnerTableReflow(nsTableOuterFrame * const 0x0293ee5c,
nsIPresContext * 0x036ffee0, nsHTMLReflowMetrics & {...}, const
nsHTMLReflowState & {...}, unsigned int & 0) line 1197 + 67 bytes
nsTableOuterFrame::IR_TargetIsInnerTableFrame(nsTableOuterFrame * const
0x0293ee5c, nsIPresContext * 0x036ffee0, nsHTMLReflowMetrics & {...}, const
nsHTMLReflowState & {...}, unsigned int & 0) line 999 + 31 bytes
nsTableOuterFrame::IR_TargetIsChild(nsTableOuterFrame * const 0x0293ee5c,
nsIPresContext * 0x036ffee0, nsHTMLReflowMetrics & {...}, const
nsHTMLReflowState & {...}, unsigned int & 0, nsIFrame * 0x0293eea8) line 971 +
31 bytes
nsTableOuterFrame::IncrementalReflow(nsTableOuterFrame * const 0x0293ee5c,
nsIPresContext * 0x036ffee0, nsHTMLReflowMetrics & {...}, const
nsHTMLReflowState & {...}, unsigned int & 0) line 950 + 35 bytes
nsTableOuterFrame::Reflow(nsTableOuterFrame * const 0x0293ee5c, nsIPresContext *
0x036ffee0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...},
unsigned int & 0) line 1406 + 31 bytes
nsBlockReflowContext::DoReflowBlock(nsHTMLReflowState & {...}, nsReflowReason
eReflowReason_Incremental, nsIFrame * 0x0293ee5c, const nsRect & {...}, int 1,
int 0, int 0, nsMargin & {...}, unsigned int & 0) line 568 + 36 bytes
nsBlockReflowContext::ReflowBlock(nsIFrame * 0x0293ee5c, const nsRect & {...},
int 1, int 0, int 0, nsMargin & {...}, unsigned int & 0) line 336 + 50 bytes
nsBlockFrame::ReflowBlockFrame(nsBlockReflowState & {...}, nsLineBox *
0x02942c44, int * 0x008ddf00) line 3929 + 56 bytes
nsBlockFrame::ReflowLine(nsBlockReflowState & {...}, nsLineBox * 0x02942c44, int
* 0x008ddf00, int 1) line 3192 + 23 bytes
nsBlockFrame::ReflowDirtyLines(nsBlockReflowState & {...}) line 2999 + 27 bytes
nsBlockFrame::Reflow(nsBlockFrame * const 0x02901bc4, nsIPresContext *
0x036ffee0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...},
unsigned int & 0) line 1771 + 15 bytes
nsBlockReflowContext::DoReflowBlock(nsHTMLReflowState & {...}, nsReflowReason
eReflowReason_Incremental, nsIFrame * 0x02901bc4, const nsRect & {...}, int 1,
int 0, int 1, nsMargin & {...}, unsigned int & 0) line 568 + 36 bytes
nsBlockReflowContext::ReflowBlock(nsIFrame * 0x02901bc4, const nsRect & {...},
int 1, int 0, int 1, nsMargin & {...}, unsigned int & 0) line 336 + 50 bytes
nsBlockFrame::ReflowBlockFrame(nsBlockReflowState & {...}, nsLineBox *
0x02901c10, int * 0x008deaa4) line 3929 + 56 bytes
nsBlockFrame::ReflowLine(nsBlockReflowState & {...}, nsLineBox * 0x02901c10, int
* 0x008deaa4, int 1) line 3192 + 23 bytes
nsBlockFrame::ReflowDirtyLines(nsBlockReflowState & {...}) line 2999 + 27 bytes
nsBlockFrame::Reflow(nsBlockFrame * const 0x02901b78, nsIPresContext *
0x036ffee0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...},
unsigned int & 0) line 1771 + 15 bytes
nsContainerFrame::ReflowChild(nsIFrame * 0x02901b78, nsIPresContext *
0x036ffee0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, int 0,
int 0, unsigned int 0, unsigned int & 0) line 692 + 31 bytes
CanvasFrame::Reflow(CanvasFrame * const 0x02900e14, nsIPresContext * 0x036ffee0,
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0)
line 304
nsBoxToBlockAdaptor::Reflow(nsBoxLayoutState & {...}, nsIPresContext *
0x036ffee0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...},
unsigned int & 0, int 0, int 0, int 8925, int 4215, int 1) line 866
nsBoxToBlockAdaptor::DoLayout(nsBoxToBlockAdaptor * const 0x02901b0c,
nsBoxLayoutState & {...}) line 523 + 52 bytes
nsBox::Layout(nsBox * const 0x02901b0c, nsBoxLayoutState & {...}) line 985
nsScrollBoxFrame::DoLayout(nsScrollBoxFrame * const 0x02900f2c, nsBoxLayoutState
& {...}) line 377
nsBox::Layout(nsBox * const 0x02900f2c, nsBoxLayoutState & {...}) line 985
nsContainerBox::LayoutChildAt(nsBoxLayoutState & {...}, nsIBox * 0x02900f2c,
const nsRect & {...}) line 591 + 16 bytes
nsGfxScrollFrameInner::LayoutBox(nsBoxLayoutState & {...}, nsIBox * 0x02900f2c,
const nsRect & {...}) line 1023 + 17 bytes
nsGfxScrollFrameInner::Layout(nsBoxLayoutState & {...}) line 1106
nsGfxScrollFrame::DoLayout(nsGfxScrollFrame * const 0x02900e84, nsBoxLayoutState
& {...}) line 1031 + 15 bytes
nsBox::Layout(nsBox * const 0x02900e84, nsBoxLayoutState & {...}) line 985
nsBoxFrame::Reflow(nsBoxFrame * const 0x02900e4c, nsIPresContext * 0x036ffee0,
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0)
line 781
nsGfxScrollFrame::Reflow(nsGfxScrollFrame * const 0x02900e4c, nsIPresContext *
0x036ffee0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...},
unsigned int & 0) line 735 + 25 bytes
nsContainerFrame::ReflowChild(nsIFrame * 0x02900e4c, nsIPresContext *
0x036ffee0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, int 0,
int 0, unsigned int 0, unsigned int & 0) line 692 + 31 bytes
ViewportFrame::Reflow(ViewportFrame * const 0x02900dd8, nsIPresContext *
0x036ffee0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...},
unsigned int & 0) line 544
nsHTMLReflowCommand::Dispatch(nsHTMLReflowCommand * const 0x03771510,
nsIPresContext * 0x036ffee0, nsHTMLReflowMetrics & {...}, const nsSize & {...},
nsIRenderingContext & {...}) line 145
PresShell::ProcessReflowCommand(nsVoidArray & {...}, int 1, nsHTMLReflowMetrics
& {...}, nsSize & {...}, nsIRenderingContext & {...}) line 5261
PresShell::ProcessReflowCommands(int 1) line 5316
ReflowEvent::HandleEvent() line 5174
HandlePLEvent(ReflowEvent * 0x037714b0) line 5188
PL_HandleEvent(PLEvent * 0x037714b0) line 588 + 10 bytes
PL_ProcessPendingEvents(PLEventQueue * 0x014cd180) line 518 + 9 bytes
_md_EventReceiverProc(HWND__ * 0x00000c80, unsigned int 55331, unsigned int 0,
long 21811584) line 1069 + 9 bytes
KERNEL32! bff7363b()
KERNEL32! bff94407()
008d8ca2()

Comment 4

[Mike Pinkerton (not reading bugmail)]

i'm filing a new bug on 

NS_PRECONDITION(PR_FALSE, "not a container");

every url does this with today's build.

Comment 5

[karnaze (gone)]

I'm seeing the 1st assertion (covered in bug 53547) but not the 2nd one. I guess 
I need to update. Moving to m0.9.

Comment 6

[karnaze (gone)]

Correction - the 1st assertion is covered in bug 73547.

Comment 7

[karnaze (gone)]

On a 3/27/1 11:30am debug WinNT build, I'm not seeing a problem (I can't even 
find the text mentioned on the page in Viewer or Nav4.x). I am seeing the 1st 
assertion which is covered in bug 73547 but not the 2nd one which would 
represent a serious problem in block code. Marking worksforme. 

Comment 8

[Mike Pinkerton (not reading bugmail)]

3/26/01 mac build shows this bug with the attached html page. reopening.

Comment 9

[Mike Pinkerton (not reading bugmail)]

Attachment: shows the text spilling from the table

Comment 10

[Mike Pinkerton (not reading bugmail)]

karnaze: i attached a screenshot. please let me know if you don't see the errant 
text when running the attached html page.

Comment 11

[Bernd]

Attachment: stack trace

Comment 12

[Bernd]

I am still seening one assert (see stack trace) the URL renders fine

Comment 13

[karnaze (gone)]

Amar, please check this on the mac (ignore the assertion which is bug 73547). It 
doesn't seem to be a problem on WinNT.

Comment 14

[Amarendra Hanumanula]

 Karnaze, I tested it on Mac 9.0 on build ID: 2001041004. The text
"Spanish-language video reports address issues important to the area's Latino
residents."
is overlapping with the table adjacent table
 

Comment 15

[karnaze (gone)]

So, this appears to be a mac only problem. If someone could develop a 
(very) reduced test case, I would try to get a mac engineer to help. I moving 
this to m0.9.1, but would give it some attention for m0.9, if a test case 
arrived soon.

Comment 16

[Brad Tiffany]

On mac build 200104608 changing the monospace font from 13px to 10px prevents
the overlap by shrinking the "Pick your city or county" select and thus the
corresponding "You live here" box. This might be a font metric coincidence
rather than a mac-only bug. Btw, mac netscape 4 exhibits a bit of overlap, as
does MacIE 5 when sufficient text zoom is applied.

Reducing this to a test case suggests that the problem is that of a table which
contains both a fixed width (unspecified width is fine) and an align=right table.
Bug 35478 appears relevant.  Test case also shows overlap on Mac Netscape 4 and
MacIE5.

Comment 17

[Brad Tiffany]

Attachment: Test case for text overlap

Comment 18

[karnaze (gone)]

Moving to m0.9.3

Comment 19

[Amarendra Hanumanula]

Adding the "testcase" keyword

Comment 20

[Blake Ross]

Doesn't look like this is getting fixed before the freeze tomorrow night. 
Pushing out a milestone.  Please correct if I'm mistaken.

Comment 21

[karnaze (gone)]

Reassigning to attinasi due to Mac only and floating table.

Comment 22

[Brad Tiffany]

In Mac build 2001082408 this page now displays fine, most likely as a result of
the fix for bug 91602 that scrapped quirks sizing for form controls.  The select
is now smaller and doesn't cause its column to expand.  I think the oversized
select was the real problem; better float handling (adequately covered in other
bugs) might just have made the page look bad in other ways.  Also, iirc, there
are at least a couple other bugs relating to large selects causing overlap on
Mac--not all involving floats.  

Comment 23

[Guillaume Filion]

This is WFM on Build 2001083008 on Mac OS 9.2.1. The Select (Pick your 
city or Country) also shows fine with this build.

Marking Worksforme. Reopen if I missed something.