Last Comment Bug 735282 - Missing border in activity manager window
: Missing border in activity manager window
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: All Windows 7
: -- normal (vote)
: Thunderbird 14.0
Assigned To: Richard Marti (:Paenglab)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-13 09:40 PDT by Andreas Nilsson (:andreasn)
Modified: 2012-03-20 14:43 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
screenshot (62.20 KB, image/png)
2012-03-13 09:40 PDT, Andreas Nilsson (:andreasn)
no flags Details
Patch (646 bytes, patch)
2012-03-18 02:29 PDT, Richard Marti (:Paenglab)
bugs: review+
bugs: ui‑review+
Details | Diff | Splinter Review

Description Andreas Nilsson (:andreasn) 2012-03-13 09:40:27 PDT
Created attachment 605428 [details]
screenshot

The activity manager window is missing a border around the content under Aero.
Comment 1 Richard Marti (:Paenglab) 2012-03-18 02:29:21 PDT
Created attachment 606952 [details] [diff] [review]
Patch

This is strange, Firefox has the same rules for downloadManager and it works but with ActivityManager it doesn't work. Normally -moz-appearance: -moz-win-glass should give a Aero window with border around the non-transparent parts but here it doesn't. Also adding -moz-appearance: -moz-win-exclude-glass; for .activityview doesn't work.

My patch adds a half-transparent border around the .activityview like we have around the main window.

It's not the best solution, but I see no other except making the window non-Aero.
Comment 2 Richard Marti (:Paenglab) 2012-03-18 02:32:51 PDT
Jim, please can you say why the Thunderbird activity manager doesn't work like the Firefox download manager with Aero Glass? The activity manager is made based on Firefox's download manager.
Comment 3 Jim Mathies [:jimm] 2012-03-19 02:55:21 PDT
This looks like fall out from bug 633282, try adding the exclude glass css property to the list view - 

http://hg.mozilla.org/mozilla-central/rev/0faa6e1353fd
Comment 4 Richard Marti (:Paenglab) 2012-03-19 04:10:47 PDT
(In reply to Jim Mathies [:jimm] from comment #3)
> This looks like fall out from bug 633282, try adding the exclude glass css
> property to the list view - 
> 
> http://hg.mozilla.org/mozilla-central/rev/0faa6e1353fd

I tried this already without luck.
Comment 5 Andreas Nilsson (:andreasn) 2012-03-20 12:24:29 PDT
Comment on attachment 606952 [details] [diff] [review]
Patch

Looks good!
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-03-20 14:43:11 PDT
http://hg.mozilla.org/comm-central/rev/b001a665472d (sorry, I forgot the ui-r= in the commit message)

Note You need to log in before you can comment on or make changes to this bug.