The default bug view has changed. See this FAQ.

IM in TB: Refocus chat tab does not update window caption; improve chat tab caption

RESOLVED FIXED in Thunderbird 13.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Thomas D. (currently busy elsewhere; needinfo?me), Assigned: florian)

Tracking

Trunk
Thunderbird 13.0
All
Windows XP

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #735292 +++

STR

current TB 13 trunk with IM client
without any IM accounts set up yet

1 press Chat button from Mail toolbar to open chat tab
2 observe chat tab caption and window caption
3 Open another tab, e.g. Tools > Addons
4 refocus chat tab
5 observe chat tab caption vs. window caption

Actual result

2: chat tab caption has "Chat - Search result": Why "Search result"?? At least for this "no chat accounts yet" scenario this really doesn't make sense, and is confusing. I doubt it makes any more sense when I populate the chat window with whatever belongs there...
But at least the tab caption is congruent with the window caption, but not for long...

5: after refocussing the chat tab, window caption doesn't update: still showing the window caption of the previously focused tab, here: "Add-ons Manager". Which is not a good window caption for the chat tab which has focus.
Expected result:

2: I'd think that just "Chat" as a tab caption is enough, at least in the "no chat accounts set up yet" scenario

5: pls update the window caption to reflect the current tab: "Chat - Daily"
(Assignee)

Comment 2

5 years ago
Created attachment 605449 [details] [diff] [review]
Trivial fix
Assignee: nobody → florian
Status: NEW → ASSIGNED
Attachment #605449 - Flags: review?
(Assignee)

Comment 3

5 years ago
Comment on attachment 605449 [details] [diff] [review]
Trivial fix

Mike volunteered to review this...

The patch is trivial: just not taking into account a hidden selected item for the update of the tab title and the central pane.

(The lack of update of the window title reported in comment 0 is because item.log was null on the hidden searchResultConv item).
Attachment #605449 - Flags: review? → review?(mconley)
Attachment #605449 - Flags: review?(mconley) → review+
Blocks: 735334
(Assignee)

Comment 4

5 years ago
http://hg.mozilla.org/comm-central/rev/e47a69dad433
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
No longer blocks: 735334
Wow, thanks Florian for fixing this so rapidly. Thank you for letting me witness this true miracle: A TB bug that gets fixed instantly after reporting... ;)
You need to log in before you can comment on or make changes to this bug.