Closed
Bug 735301
Opened 12 years ago
Closed 12 years ago
IM in TB: Refocus chat tab does not update window caption; improve chat tab caption
Categories
(Thunderbird :: Instant Messaging, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 13.0
People
(Reporter: thomas8, Assigned: florian)
References
Details
Attachments
(1 file)
1.78 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #735292 +++ STR current TB 13 trunk with IM client without any IM accounts set up yet 1 press Chat button from Mail toolbar to open chat tab 2 observe chat tab caption and window caption 3 Open another tab, e.g. Tools > Addons 4 refocus chat tab 5 observe chat tab caption vs. window caption Actual result 2: chat tab caption has "Chat - Search result": Why "Search result"?? At least for this "no chat accounts yet" scenario this really doesn't make sense, and is confusing. I doubt it makes any more sense when I populate the chat window with whatever belongs there... But at least the tab caption is congruent with the window caption, but not for long... 5: after refocussing the chat tab, window caption doesn't update: still showing the window caption of the previously focused tab, here: "Add-ons Manager". Which is not a good window caption for the chat tab which has focus.
Reporter | ||
Comment 1•12 years ago
|
||
Expected result: 2: I'd think that just "Chat" as a tab caption is enough, at least in the "no chat accounts set up yet" scenario 5: pls update the window caption to reflect the current tab: "Chat - Daily"
Assignee | ||
Comment 2•12 years ago
|
||
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 605449 [details] [diff] [review] Trivial fix Mike volunteered to review this... The patch is trivial: just not taking into account a hidden selected item for the update of the tab title and the central pane. (The lack of update of the window title reported in comment 0 is because item.log was null on the hidden searchResultConv item).
Attachment #605449 -
Flags: review? → review?(mconley)
Updated•12 years ago
|
Attachment #605449 -
Flags: review?(mconley) → review+
Assignee | ||
Comment 4•12 years ago
|
||
http://hg.mozilla.org/comm-central/rev/e47a69dad433
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
Reporter | ||
Comment 5•12 years ago
|
||
Wow, thanks Florian for fixing this so rapidly. Thank you for letting me witness this true miracle: A TB bug that gets fixed instantly after reporting... ;)
You need to log in
before you can comment on or make changes to this bug.
Description
•