Last Comment Bug 735301 - IM in TB: Refocus chat tab does not update window caption; improve chat tab caption
: IM in TB: Refocus chat tab does not update window caption; improve chat tab c...
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Instant Messaging (show other bugs)
: Trunk
: All Windows XP
: -- normal (vote)
: Thunderbird 13.0
Assigned To: Florian Quèze [:florian] [:flo]
:
Mentors:
Depends on:
Blocks: 714733
  Show dependency treegraph
 
Reported: 2012-03-13 10:11 PDT by Thomas D. (currently busy elsewhere; needinfo?me)
Modified: 2012-03-13 11:44 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Trivial fix (1.78 KB, patch)
2012-03-13 10:36 PDT, Florian Quèze [:florian] [:flo]
mconley: review+
Details | Diff | Splinter Review

Description Thomas D. (currently busy elsewhere; needinfo?me) 2012-03-13 10:11:54 PDT
+++ This bug was initially created as a clone of Bug #735292 +++

STR

current TB 13 trunk with IM client
without any IM accounts set up yet

1 press Chat button from Mail toolbar to open chat tab
2 observe chat tab caption and window caption
3 Open another tab, e.g. Tools > Addons
4 refocus chat tab
5 observe chat tab caption vs. window caption

Actual result

2: chat tab caption has "Chat - Search result": Why "Search result"?? At least for this "no chat accounts yet" scenario this really doesn't make sense, and is confusing. I doubt it makes any more sense when I populate the chat window with whatever belongs there...
But at least the tab caption is congruent with the window caption, but not for long...

5: after refocussing the chat tab, window caption doesn't update: still showing the window caption of the previously focused tab, here: "Add-ons Manager". Which is not a good window caption for the chat tab which has focus.
Comment 1 Thomas D. (currently busy elsewhere; needinfo?me) 2012-03-13 10:13:54 PDT
Expected result:

2: I'd think that just "Chat" as a tab caption is enough, at least in the "no chat accounts set up yet" scenario

5: pls update the window caption to reflect the current tab: "Chat - Daily"
Comment 2 Florian Quèze [:florian] [:flo] 2012-03-13 10:36:58 PDT
Created attachment 605449 [details] [diff] [review]
Trivial fix
Comment 3 Florian Quèze [:florian] [:flo] 2012-03-13 10:55:05 PDT
Comment on attachment 605449 [details] [diff] [review]
Trivial fix

Mike volunteered to review this...

The patch is trivial: just not taking into account a hidden selected item for the update of the tab title and the central pane.

(The lack of update of the window title reported in comment 0 is because item.log was null on the hidden searchResultConv item).
Comment 4 Florian Quèze [:florian] [:flo] 2012-03-13 11:33:48 PDT
http://hg.mozilla.org/comm-central/rev/e47a69dad433
Comment 5 Thomas D. (currently busy elsewhere; needinfo?me) 2012-03-13 11:44:50 PDT
Wow, thanks Florian for fixing this so rapidly. Thank you for letting me witness this true miracle: A TB bug that gets fixed instantly after reporting... ;)

Note You need to log in before you can comment on or make changes to this bug.