735306 - Mistake in certcgi.c source code

Status: RESOLVED FIXED

(NSS :: Tools, defect)

Description

[GuyV]

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; .NET CLR 2.0.50727; .NET CLR 3.0.04506.648; .NET CLR 3.5.21022; .NET CLR 1.1.4322; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; MS-RTC LM 8; .NET4.0C)

Steps to reproduce:

Ran cppcheck V1.52: it found a bug in certcgi.c
More specific: security\nss\cmd\certcgi\certcgi.c at row :1432
The code in question is: if (value >= 0 || value < 256) {
This is alway's true! That can't be a usefull check!

The reported error by cppcheck is: (warning) Mutual exclusion over || always evaluates to true. Did you intend to use && instead?


Actual results:

Verified the reported error of cppcheck.
In this case cppcheck is right, && should have been used.


Expected results:

Replace || with && on:
security\nss\cmd\certcgi\certcgi.c at row :1432
--if (value >= 0 || value < 256) {
++if (value >= 0 && value < 256) {
OR remove this entire check. (The check is useless, so it needs to be modified or removed.)

Comment 1

[Ludovic Hirlimann [:Usul]]

Guy do you feel like making a patch ?

Comment 2

[GuyV]

Attachment: patch for bug 735306 /r

patch for bug 735306 /r

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 605514 [details] [diff] [review]
patch for bug 735306 /r

r+

Comment 4

[Ludovic Hirlimann [:Usul]]

Can this be flagged chedkin needed ?

Comment 5

[Kai Engert [:KaiE:]]

Guy, thank you for your contribution (although this code might no longer be in use).

Checking in certcgi/certcgi.c;
/cvsroot/mozilla/security/nss/cmd/certcgi/certcgi.c,v  <--  certcgi.c
new revision: 1.22; previous revision: 1.21
done