Closed
Bug 735318
Opened 12 years ago
Closed 10 years ago
Chatting notification only show the selected conversation not the one notifying me.
Categories
(Thunderbird :: Instant Messaging, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 37.0
People
(Reporter: Usul, Assigned: sshagarwal)
Details
(Keywords: ux-efficiency)
Attachments
(2 files)
38.34 KB,
image/png
|
Details | |
1.57 KB,
patch
|
aleth
:
review+
Paenglab
:
ui-review+
aleth
:
feedback+
|
Details | Diff | Splinter Review |
Str : Chat with two people Select first chat where the user is inactive second chat is active and sends a new message the tab notification talks about a new message on the selected and inactive chat. (see screenshot)
Comment 1•10 years ago
|
||
I believe you have fixed this -- please resolve the bug if that is the case.
Flags: needinfo?(syshagarwal)
Assignee | ||
Comment 2•10 years ago
|
||
Ya, this is the behavior we see as of now. But, how can we show a "new message" notification on the active chat? Since, it will be read as it arrives. Can you please tell me what should be the expected behavior? Thanks.
Flags: needinfo?(syshagarwal)
Comment 3•10 years ago
|
||
It's currently "Chat(N) - Name of active chat" where N is the *sum* of all the unread messages in all chats, see chat-messenger-overlay.js::updateTitle. I can see why it could be confusing, but was probably done that way so as to make sense when the chat tab is not the active tab. Would a good solution be to not show unread message counts in the tab title at all while the chat tab is the active tab?
Flags: needinfo?(richard.marti)
Comment 4•10 years ago
|
||
Removing the counter on active tab could help to be less confusing. But then what about removing the name of the active chat on inactive tab? Then the counter shows clearly the sum of all chats and no direct relation to the active chat in title would be made.
Flags: needinfo?(richard.marti)
Comment 5•10 years ago
|
||
(In reply to Richard Marti (:Paenglab) from comment #4) > Removing the counter on active tab could help to be less confusing. But then > what about removing the name of the active chat on inactive tab? Then the > counter shows clearly the sum of all chats and no direct relation to the > active chat in title would be made. This combination sounds like a good solution.
Assignee | ||
Comment 6•10 years ago
|
||
So, if the idea is that we remove the active chat's contact's name if there are unread messages so as to avoid ambiguous states, here's the patch. Please let me know if this is okay. Thanks.
Attachment #8536051 -
Flags: ui-review?(richard.marti)
Attachment #8536051 -
Flags: feedback?(aleth)
Comment 7•10 years ago
|
||
Comment on attachment 8536051 [details] [diff] [review] Patch v1 Yes, like this there is no confusion to there the counter relates.
Attachment #8536051 -
Flags: ui-review?(richard.marti) → ui-review+
Comment 8•10 years ago
|
||
Comment on attachment 8536051 [details] [diff] [review] Patch v1 Review of attachment 8536051 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/components/im/content/chat-messenger-overlay.js @@ +315,5 @@ > + let selectedItem = document.getElementById("contactlistbox").selectedItem; > + if (selectedItem && selectedItem.localName == "imconv" && > + !selectedItem.hidden) > + title += " - " + selectedItem.getAttribute("displayname"); > + } This doesn't do what comment 4 describes. The idea there is if (chat tab selected) title = chat tab title + active conv name if it exists else title = chat tab title + (total unread count)
Attachment #8536051 -
Flags: feedback?(aleth) → feedback-
Comment 9•10 years ago
|
||
(In reply to aleth [:aleth] from comment #8) However, if Paenglab and you think the behaviour in this patch is better than what's in comment 4, then I'm OK with that!
Updated•10 years ago
|
Attachment #8536051 -
Flags: feedback- → feedback+
Comment 10•10 years ago
|
||
(In reply to aleth [:aleth] from comment #9) > (In reply to aleth [:aleth] from comment #8) > > However, if Paenglab and you think the behaviour in this patch is better > than what's in comment 4, then I'm OK with that! I think this one is the best approach. When the tab is selected there is no direct need to show the name of the actual chat and hide the counter. I think it's more important to show the counter than the active chat. The chat with new message could be scrolled out of the view and then you don't remark the new message.
Comment 11•10 years ago
|
||
Comment on attachment 8536051 [details] [diff] [review] Patch v1 Review of attachment 8536051 [details] [diff] [review]: ----------------------------------------------------------------- OK, let's ship it!
Attachment #8536051 -
Flags: review+
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 12•10 years ago
|
||
(In reply to aleth [:aleth] from comment #8) Actually I just have these reversed. > if (unread count) > title = chat tab title + (total Unread count) > else > title = chat tab title "-" + active conv name if it exists Thanks.
Assignee: nobody → syshagarwal
Status: NEW → ASSIGNED
Comment 13•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/4d5c64fd007e -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 37.0
Updated•10 years ago
|
Keywords: checkin-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•