Closed Bug 735332 Opened 13 years ago Closed 13 years ago

New Hook in bugmail templates

Categories

(Bugzilla :: Extensions, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 4.4

People

(Reporter: rgduarte, Assigned: rgduarte)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Add new hook (obsolete) — Splinter Review
User Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.21) Gecko/20110830 Ubuntu/10.04 (lucid) Firefox/3.6.21 Build ID: 20110830191619 Steps to reproduce: Enhancement to add a new hook inside bugmail.html and bugmail.txt templates.
Attachment #605454 - Flags: review?(timello)
Severity: normal → enhancement
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attached patch Improved patchSplinter Review
Attachment #605464 - Flags: review?(timello)
Could we have some real examples of what you try to do with these hooks?
Assignee: extensions → rgduarte
Attachment #605454 - Attachment is obsolete: true
Attachment #605454 - Flags: review?(timello)
(In reply to Frédéric Buclin from comment #2) > Could we have some real examples of what you try to do with these hooks? We need to warn users that some of the comments are private and may contain confidential information. Also, this hook allows you to customize the HTML bugmail with a header or anything useful for you.
Comment on attachment 605464 [details] [diff] [review] Improved patch It does what it is proposed for. Also, it passes in all tests.
Attachment #605464 - Flags: review?(timello) → review+
Flags: approval?
Flags: approval4.2?
Btw, the new hook does not add any new space/line in the email if it's not in use.
I don't think we need them for 4.2, right?
Flags: approval?
Flags: approval4.2?
Flags: approval4.2-
Flags: approval+
Target Milestone: --- → Bugzilla 4.4
Thanks Renata! Committing to: bzr+ssh://timello%40gmail.com@bzr.mozilla.org/bugzilla/trunk/ modified template/en/default/email/bugmail.html.tmpl modified template/en/default/email/bugmail.txt.tmpl Committed revision 8156.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: