Closed
Bug 735332
Opened 13 years ago
Closed 13 years ago
New Hook in bugmail templates
Categories
(Bugzilla :: Extensions, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.4
People
(Reporter: rgduarte, Assigned: rgduarte)
Details
Attachments
(1 file, 1 obsolete file)
|
812 bytes,
patch
|
timello
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.21) Gecko/20110830 Ubuntu/10.04 (lucid) Firefox/3.6.21
Build ID: 20110830191619
Steps to reproduce:
Enhancement to add a new hook inside bugmail.html and bugmail.txt templates.
| Assignee | ||
Updated•13 years ago
|
Attachment #605454 -
Flags: review?(timello)
Updated•13 years ago
|
Severity: normal → enhancement
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
| Assignee | ||
Comment 1•13 years ago
|
||
Attachment #605464 -
Flags: review?(timello)
Comment 2•13 years ago
|
||
Could we have some real examples of what you try to do with these hooks?
Updated•13 years ago
|
Assignee: extensions → rgduarte
Updated•13 years ago
|
Attachment #605454 -
Attachment is obsolete: true
Attachment #605454 -
Flags: review?(timello)
Comment 3•13 years ago
|
||
(In reply to Frédéric Buclin from comment #2)
> Could we have some real examples of what you try to do with these hooks?
We need to warn users that some of the comments are private and may contain confidential information. Also, this hook allows you to customize the HTML bugmail with a header or anything useful for you.
Comment 4•13 years ago
|
||
Comment on attachment 605464 [details] [diff] [review]
Improved patch
It does what it is proposed for. Also, it passes in all tests.
Attachment #605464 -
Flags: review?(timello) → review+
Updated•13 years ago
|
Flags: approval?
Flags: approval4.2?
Comment 5•13 years ago
|
||
Btw, the new hook does not add any new space/line in the email if it's not in use.
Comment 6•13 years ago
|
||
I don't think we need them for 4.2, right?
Flags: approval?
Flags: approval4.2?
Flags: approval4.2-
Flags: approval+
Target Milestone: --- → Bugzilla 4.4
Comment 7•13 years ago
|
||
Thanks Renata!
Committing to: bzr+ssh://timello%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/email/bugmail.html.tmpl
modified template/en/default/email/bugmail.txt.tmpl
Committed revision 8156.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•