Participant list of IRC channels isn't finished

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

Trunk
Thunderbird 14.0

Thunderbird Tracking Flags

(thunderbird13 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
- The tooltips (supposed to display whois results) don't work:
Error: document.getBindingParent(elt) is null
Source File: chrome://messenger/content/chat/imbuddytooltip.xml
Line: 398

- double clicking on a nick to start a private conversation doesn't work:
Error: onNickClick is not defined
Source File: chrome://messenger/content/messenger.xul
Line: 1

- pressing enter to start a private conversation with the selected nick doesn't work:
Error: onNicklistKeyPress is not defined
Source File: chrome://messenger/content/messenger.xul
Line: 1
(Assignee)

Updated

5 years ago
Duplicate of this bug: 735999
(Assignee)

Comment 2

5 years ago
Created attachment 606165 [details] [diff] [review]
Patch
Assignee: nobody → florian
Status: NEW → ASSIGNED
Attachment #606165 - Flags: review?(bwinton)
Comment on attachment 606165 [details] [diff] [review]
Patch

>+++ b/mail/components/im/content/chat-messenger-overlay.js
>@@ -430,16 +430,44 @@ var chatHandler = {
>+  onNicklistKeyPress: function(aEvent) {
>+    if (aEvent.keyCode != aEvent.DOM_VK_RETURN &&
>+        aEvent.keyCode != aEvent.DOM_VK_ENTER)
>+      return;
>+
>+    let listbox = aEvent.originalTarget;
>+    if (listbox.selectedCount == 0)
>+      return;
>+
>+    let conv = document.getElementById("contactlistbox").selectedItem.conv;
>+    for (let i = 0; i < listbox.selectedCount; ++i) {
>+      let nick = listbox.getSelectedItem(i).chatBuddy.name;
>+      let name = conv.target.getNormalizedChatBuddyName(nick);
>+      conv.account.createConversation(name);
>+    }
>+  },
>+

Huh.  I think I would want hitting enter to open a single group chat with all the selected nicks, not a new chat with each nick…

On the other hand, I can't seem to select more than one nick in the nicklist, so perhaps it's not a problem in practice.

> - The tooltips (supposed to display whois results) don't work:

It works!  Woo!  ;)

> - double clicking on a nick to start a private conversation doesn't work:
> Error: onNickClick is not defined
> Source File: chrome://messenger/content/messenger.xul
> Line: 1
>
> - pressing enter to start a private conversation with the selected nick doesn't work:
> Error: onNicklistKeyPress is not defined
> Source File: chrome://messenger/content/messenger.xul
> Line: 1

These still fail (for twitter) with:
JavaScript error: , line 0: uncaught exception: [Exception... "'Method not implemented' when calling method: [prplIAccount::createConversation]"  nsresult: "0x80004001 (NS_ERROR_NOT_IMPLEMENTED)"  location: "JS frame :: file:///Volumes/SSD/Programming/thunderbird/objdir-comm-central-default/mozilla/dist/DailyDebug.app/Contents/MacOS/components/imAccounts.js :: <TOP_LEVEL> :: line 650"  data: no]

I think we should probably wrap the calls to "conv.account.createConversation(name);" in onNickClick and onNicklistKeyPress with a try/catch.

r=me with that fixed.  ;)

Thanks,
Blake.
Attachment #606165 - Flags: review?(bwinton) → review+
(Assignee)

Comment 4

5 years ago
Created attachment 610052 [details] [diff] [review]
As checked in
(Assignee)

Comment 5

5 years ago
http://hg.mozilla.org/comm-central/rev/0ee50ffb3901
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
(Assignee)

Comment 6

5 years ago
Comment on attachment 610052 [details] [diff] [review]
As checked in

[Approval Request Comment]
User impact if declined: the list of channel participants is currently quite broken on aurora.
Attachment #610052 - Flags: approval-comm-aurora?

Updated

5 years ago
Attachment #610052 - Flags: approval-comm-aurora? → approval-comm-aurora+
(Assignee)

Comment 7

5 years ago
http://hg.mozilla.org/releases/comm-aurora/rev/8ab141032937
status-thunderbird13: --- → fixed
You need to log in before you can comment on or make changes to this bug.