735447 - Navigator mozapps - installOrigin

Status: RESOLVED INVALID

(Web Apps :: Soup, defect)

Description

[[e-mail] [:onecyrenus]]

The installOrigin field as defined by mozilla-central implentation is returning the hostname:port of the originating site to issue the install request. 

The installOrigin field as defined by html / js & android implementation stores the hostname & port of the web application. 

dom/js/webapps.js
>  let installOrigin = this._getOrigin(this._window.location.href);

This is a bug in the html / js implementation.

Comment 1

[Ian Bicking (:ianbicking)]

I am realizing that repo_api.html does not test this - it is rather vague about what installOrigin is set to.  I improved the test slightly: https://github.com/mozilla/openwebapps/commit/acfeb00a03c5351a820a60beedefaec3282a6aa6

I believe the HTML implementation is correct (and this test passes).

Comment 2

[Anant Narayanan [:anant]]

The add-on implement this incorrectly, we'll leave this bug open to track that.

Comment 3

[Anant Narayanan [:anant]]

On looking more closely, the add-on does in fact implement this correctly, I was misled by a rogue variable named 'origin', which should have been named 'installOrigin'.

Let's figure out why the test is failing for David, but not for Ian.

Comment 4

[[e-mail] [:onecyrenus]]

i think this was fixed in the past, git pull issue.