73551 - js warnings in msgMail3PaneWindow.js and msgViewNavigation.js

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

these are probably covered in other bugs, but I need a place to attach my patch.

Comment 1

[(not reading, please use [e-mail] instead)]

here comes a patch

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: fix

Comment 3

[Håkan Waara]

It's kind of hard to review this bug w/o the errors reported.

Why are you removing the 'outlinerview' variable? That is used a few lines below.

Comment 4

[(not reading, please use [e-mail] instead)]

hwaara, the variable is defined and assigned a few lines up.

I'll provide the js warnings this afternoon.

Comment 5

[Håkan Waara]

Ah, I checked LXR and now I see. r=hwaara

Comment 6

[(not reading, please use [e-mail] instead)]

here are the warnings:

JavaScript strict warning:
chrome://messenger/content/msgViewNavigation.js line 107: function
CrossFolderNavigation does not always return a value

JavaScript strict warning:
chrome://messenger/content/msgViewNavigation.js line 171: function
CrossFolderNavigation does not always return a value

WARNING: waaah!, file nsXULPrototypeDocument.cpp, line 523
JavaScript strict warning:
chrome://messenger/content/msgMail3PaneWindow.js line 206: redeclaration of var
outlinerView

Comment 7

[(not reading, please use [e-mail] instead)]

fixed.

Comment 8

[esther]

Using 2001-04-04 on windows and ran app with 3-pane window, navigating to Next 
folder with next Unread button while console was up and did not see the js 
warnings.  Verified.